683722 - Workers cannot be created on URLs with IP addresses or localhost

Status: RESOLVED DUPLICATE of bug 683280

(Core :: DOM: Core & HTML, defect)

Description

[Alon Zakai (:azakai)]

Attachment: patch

For example, to see this you can do

  new Worker('x')

in the web console here on bugzilla. The result is |Script file not found|, as expected. But if you connect to an IP address, for example run a local webserver and connect to 127.0.0.1:8000, the same command gives |Error: Could not get domain!|.

The cause is that WorkerPrivate::Create tries to get the domain. But an IP address or localhost are not valid inputs for tldService->GetBaseDomain.

The attached patch fixes things for IP addresses. I'm not sure what the right way to fix things for localhost is (but localhost is a much smaller problem I think).

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

We have bug 683280 for localhost.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Actually, let's dup to bug 683280 and use the thirdpartyutil code there for both fixes?

Comment 3

[Alon Zakai (:azakai)]

Sounds good.