12.32 KB, patch
|Details | Diff | Splinter Review|
9.45 KB, patch
Ben Turner (not reading bugmail, use the needinfo flag!): review+
|Details | Diff | Splinter Review|
Any attempts to create a worker from localhost: new Worker("http://localhost/~gozala/Projects/ace/ace/lib/ace/worker/worker.js") new Worker("/~gozala/Projects/ace/ace/lib/ace/worker/worker.js") new Worker("./worker/worker.js") fails with errors: [22:01:08.724] Error: Could not get domain! Both on latest Aurora and Nightly. Also same code works with FF 6.0 What's also interesting is that this issue does not seems to happen if page is accessed via http://jarti.lan/~gozala/Projects/ace/ace/ instead in which case worker URL is: new Worker("http://jarti.lan/~gozala/Projects/ace/ace/lib/ace/worker/worker.js")
For the localhost case, are you accessing the page via http://localhost, or via file:// ?
(In reply to Boris Zbarsky (:bz) from comment #1) > For the localhost case, are you accessing the page via http://localhost, or > via file:// ? localhost it's http://localhost/~gozala/Projects/ace/ace/
Looks like WorkerPrivate::Create tries to do something with the tld service.. which presumably fails for localhost. Ben, what's that code trying to do?
And is this a problem on the beta channel?
We try to limit the number of workers per domain, apparently TLDService doesn't support localhost so we'll just need to add another special case I guess.
Could we just check for NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS and do something sane with it?
Sure. Maybe we should just try to reuse ThirdPartyUtil::GetBaseDomain, it seems much better.
Alon, see comment 7?
Created attachment 557615 [details] [diff] [review] Patch, v1
Backed out as part of <http://hg.mozilla.org/integration/mozilla-inbound/rev/cc0753a23f8b> because of mochitest-3 crashes like this: <https://tbpl.mozilla.org/php/getParsedLog.php?id=6340142&full=1>
Better, this time it was just test_ipAddressOrigin.html timing out. Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/70411e3adb66
There's some problem with using 127.0.0.1 on linux in our test setup... Other OS seem fine. Not sure what's going on, we'll need to investigate more. For now, checked into inbound without the test: https://hg.mozilla.org/integration/mozilla-inbound/rev/756d9bfae05d
Created attachment 567130 [details] [diff] [review] Patch for branches This is the patch for branches (simply adds a new interface rather than bumping the existing iid).
Comment on attachment 567130 [details] [diff] [review] Patch for branches Per todays triage meeting this doesn't seem like a large enough problem to take on branches. If we missed something, please renominate and state why this is important to fix now rather than a few weeks later.
---------------------------------[ Triage Comment ]--------------------------------- Though it is a regression the problem seems small and generally not web facing. We will not track this for a specific Firefox version. The patch appears to have landed on mozilla-central/Firefox 10 in any case.
WaveMaker studio is a development environment that runs on localhost and uses the ACE Editor (ace.ajax.org) which uses workers. All of our users who use FireFox were automatically upgraded from a version where the development environment worked to one where it did not (Ok, it works, but with a crippled editor). We are now able to provide a significantly better user experience to developers using Chrome than FireFox because of this issue. I'd appreciate any information on which version of FireFox this fix will be available for; I'm going to have to post to my user community telling them NOT to upgrade to FireFox 8, and I'm sure they'd appreciate knowing how long they're going to be fighting against your automatic upgrade system.
As things currently stand, this will get fixed in Firefox 10. Renominating based on your feedback.
Stepwells web based application is relying on the use of local web workers. this bug caused us a lot of trouble, we needed to change our entire application design and tell our users to downgrade from firefox 8, or force them to use Chrome. we are eagerly awaiting response on this issue and when will it be fixed.
Also affects the embedded editors of cde.webdetails.org (what we use in the mozilla metrics team to build the dashboards)
We've got reports of multiple broken apps here ... and we're considering taking the fix for blob URI works for 8.0.1, so we should probably consider this too.
Comment on attachment 567130 [details] [diff] [review] Patch for branches /me sets the flags he meant to set.
will this fix be out in the next ff 8.0.1 version? or is it still expected in ff 10 ?
I think it's going to be in Firefox 9 now.
I'm going to assume that the approval-mozilla-release here was a mistake. LegNeato isn't answering me on IRC :-/
Comment on attachment 567130 [details] [diff] [review] Patch for branches That's a safe assumption - we don't know whether we're re-spinning so denying for approval-mozilla-release for now, but will leave the FF8 tracking flag as ?.
We're watching this closely but for now it did not make 8.0.1. If other issues crop up we will consider this as a ride-along now that the extent of the problem is greater than previously thought. We are building Firefox 9 beta 2 today and by the end of the week it should be on the beta channel. You can point users to that if you'd like. It should be fixed in Fx 9 proper, due December 20th.
Is this something QA can verify?
FYI: I'm seeing this error when using http://127.0.0.1 on FF8.0 on Ubuntu Linux, so I'm not sure there's a reasonable path to test WebWorkers on a local machine, short of /etc/hosts, which is kind of unfortunate.
Setting resolution to Verified fixed on: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:9.0) Gecko/20100101 Firefox/9.0 I've followed the steps from comment36 and everything works as expected. No errors.
Can we get specific steps to reproduce on this? I tried Wavemaker in Mac Fx 8.0.1, and did get a couple of domain errors similar to Comment 0. However, I got them on the initial load of Wavemaker, and had no further errors creating projects or going to the source pane, nor did I see any app misbehavior (to the extent I understand the app). I did not get these errors in 10.0b2, which I suspect means we're good. However, until I understand exactly where the errors are supposed to appear I do not want to mark it this verified.
Hi Geo. Have you found any new errors? I was testing this on Firefox 10b6 on MacOSX 10.6.8 and I got the following error "Error: not well-formed Source File: http://localhost:8094/wavemaker/lib/build/Gzipped/lib_build.js Line: 1, Column: 1 Source Code: /*" (In reply to Geo Mealer [:geo] from comment #39) > Can we get specific steps to reproduce on this? > > I tried Wavemaker in Mac Fx 8.0.1, and did get a couple of domain errors > similar to Comment 0. However, I got them on the initial load of Wavemaker, > and had no further errors creating projects or going to the source pane, nor > did I see any app misbehavior (to the extent I understand the app). > > I did not get these errors in 10.0b2, which I suspect means we're good. > However, until I understand exactly where the errors are supposed to appear > I do not want to mark it this verified.