Closed Bug 684276 Opened 8 years ago Closed 8 years ago

Android Menu labels should wrap or at least crop themselves

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 9

People

(Reporter: wesj, Assigned: wesj)

References

Details

(Whiteboard: [inbound])

Attachments

(1 file)

patch v1
547 bytes, patch
mbrubeck
: review+
Details | Diff | Splinter Review 
Just noticed that my new awesome android menu doesn't look quite right on Spanish Fennec. They're using much longer labels, and they overflow into neighbouring boxes. I believe Ian's mockups showed labels wrapping.
Blocks: 655762
Attached patch patch v1 — — Splinter Review 
Since labels aren't going to wrap, I'm using label.textContent instead.
Assignee: nobody → wjohnston
Attachment #557908 - Flags: review?(mbrubeck)
Comment on attachment 557908 [details] [diff] [review]
patch v1

Looks fine to me, though I had no idea that label.value and label.textContent would lay out differently (and I still have no idea why)...
Attachment #557908 - Flags: review?(mbrubeck) → review+
http://hg.mozilla.org/mozilla-central/rev/f4af15996729
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110806 Firefox/9.0a1 Fennec/9.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.