Improve styling of Web Console on Windows

RESOLVED FIXED in Firefox 9

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

Trunk
Firefox 9
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 2 obsolete attachments)

Created attachment 558120 [details]
Screenshot of the bug

We should add some margins between the filter buttons, and place the close button on the right-side.

See attached screenshot for details.
Assignee: nobody → jwein
Status: NEW → ASSIGNED
Created attachment 558213 [details] [diff] [review]
Patch for bug 684561

Moved the close button to the right side and added some margins between the buttons.
Attachment #558213 - Flags: review?(dao)
Created attachment 558214 [details]
Screenshot of the patch
Attachment #558214 - Flags: feedback?(faaborg)
Comment on attachment 558213 [details] [diff] [review]
Patch for bug 684561

HUDService.jsm should append the close button to the end in the DOM (except for OS X maybe).
Attachment #558213 - Flags: review?(dao) → review-
Created attachment 558241 [details] [diff] [review]
Patch for bug 684561 v2

Updated HUDService.jsm to place the close button at the end of the DOM if not on OS X.
Attachment #558213 - Attachment is obsolete: true
Attachment #558241 - Flags: review?(dao)
Comment on attachment 558241 [details] [diff] [review]
Patch for bug 684561 v2

>-    this.makeCloseButton(toolbar);
>+    let osString = Cc["@mozilla.org/xre/app-info;1"].
>+                   getService(Ci.nsIXULRuntime).OS;
>+    if (osString == "Darwin")
>+      this.makeCloseButton(toolbar);
> 
>     for (let i = 0; i < BUTTONS.length; i++) {
>       this.makeFilterButton(toolbar, BUTTONS[i]);
>     }
> 
>     toolbar.appendChild(this.filterSpacer);
> 
>     let positionUI = this.createPositionUI();
>     toolbar.appendChild(positionUI);
> 
>     toolbar.appendChild(this.filterBox);
>     this.makeClearConsoleButton(toolbar);
> 
>+    if (osString != "Darwin")
>+      this.makeCloseButton(toolbar);

This should use ifdefs. Look for EXTRA_PP_JS_MODULES for how to enable this.

>+.webconsole-filter-button > .toolbarbutton-menubutton-button,
>+.webconsole-filter-button > .toolbarbutton-menubutton-button:hover:active {
>+  -moz-padding-start: 6px !important;
>+  -moz-padding-end: 3px !important;
>+}

Why is !important needed here?
Does -moz-padding-end actually change something? I can't see it in the screenshots.
Attachment #558241 - Flags: review?(dao) → review-
Created attachment 558250 [details] [diff] [review]
Patch for bug 684561 v3

The !important rules were a carry-over from previous tweaks and weren't needed. Thank you for catching them.

I have attempted (and it appears I was successful), at using EXTRA_PP_JS_MODULES, but I am not sure if I used it the way that you meant.
Attachment #558241 - Attachment is obsolete: true
Attachment #558250 - Flags: review?(dao)
> Does -moz-padding-end actually change something? I can't see it in the
> screenshots.

I forgot to mention that -moz-padding-end is needed because there is a rule in toolbarbutton.css sets the padding to 2px on :hover:active, causing the toolbarbutton to shrink by 1 pixel.

Updated

6 years ago
Attachment #558250 - Flags: review?(dao) → review+
Sweet! Thanks for doing this. :)
Attachment #558214 - Flags: feedback?(faaborg) → feedback+
http://hg.mozilla.org/integration/fx-team/rev/d1c042be8802
Whiteboard: [fixed-in-fx-team]
http://hg.mozilla.org/mozilla-central/rev/d1c042be8802
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 9
Depends on: 686778
You need to log in before you can comment on or make changes to this bug.