685282 - [TABLETUI] Update Actionbar icons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: New icon assets

Let's update the icons to go better with the new grey header.

Comment 1

[Ian Barlow (:ibarlow)]

Attachment: Mockups of portait / landscape actionbars, for reference

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch v1

I accidentally combined this with a patch for bug 685289 (same thing for the honeycomb app menu), but don't see any huge reason to pick them apart. This does look a bit funny to me right now though. Maybe because of some other patches (circle back button, conditional forward, etc. that haven't landed?). Screenshot at:

http://people.mozilla.com/~wjohnston/screenshots/newicons.png

if its deemed too ugly I'll come back and see what else we need to change.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 561242 [details] [diff] [review]
Patch v1

looks OK to me

Comment 4

[Ian Barlow (:ibarlow)]

Wesj, looks good for now! The circle back and conditional forward bugs will pull it all together :)

Comment 5

[Wesley Johnston (:wesj)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/3b962e7590f1

Comment 6

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/3b962e7590f1

Comment 7

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110922
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1