Closed Bug 685308 Opened 8 years ago Closed 8 years ago

Make tablet UI work in RTL locales

Categories

(Firefox for Android Graveyard :: General, defect, P3)

Firefox 9
All
Android
defect

Tracking

(fennec-)

VERIFIED FIXED
Firefox 9
Tracking Status
fennec - ---

People

(Reporter: mbrubeck, Assigned: mbrubeck)

References

Details

(Keywords: rtl)

Attachments

(2 files)

The tablet UI has some problems in RTL locales, especially the layout of the tab thumnails in the tabs sidebar.

We'll probably need to create mirrored versions of some of the assets like the tab image.
no RTl locales installed by default.  setting lower priority
Priority: -- → P3
tracking-fennec: ? → -
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Depends on: 686417
Whiteboard: [has patch]
Attachment #561897 - Flags: review?(mark.finkle)
I tested this in all three themes, in both RTL and LTR modes.

I'm a little curious about the "-moz-box-align:start" that I removed.  It was set only in RTL mode, and as far as I could tell it had no effect in phone mode but totally broke the tablet UI.  I'll see if I can figure out why it was added in the first place.
Attachment #561897 - Attachment is obsolete: true
Attachment #561897 - Flags: review?(mark.finkle)
Attachment #561912 - Flags: review?(wjohnston)
Comment on attachment 561897 [details] [diff] [review]
part 1: Make sidebar dragging work in RTL

I didn't mean to obsolete this.
Attachment #561897 - Attachment is obsolete: false
Attachment #561897 - Flags: review?(mark.finkle)
Attachment #561912 - Flags: review?(wjohnston) → review+
Attachment #561897 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/mozilla-central/rev/1e9807475e1e
https://hg.mozilla.org/mozilla-central/rev/94852085df97
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1
Status: RESOLVED → VERIFIED
Depends on: 691338
You need to log in before you can comment on or make changes to this bug.