685308 - Make tablet UI work in RTL locales

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Matt Brubeck (:mbrubeck)]

The tablet UI has some problems in RTL locales, especially the layout of the tab thumnails in the tabs sidebar.

We'll probably need to create mirrored versions of some of the assets like the tab image.

Comment 1

[Tony Chung [:tchung]]

no RTl locales installed by default.  setting lower priority

Comment 2

[Matt Brubeck (:mbrubeck)]

Attachment: part 1: Make sidebar dragging work in RTL

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: part 2: make tablet theme work in RTL

I tested this in all three themes, in both RTL and LTR modes.

I'm a little curious about the "-moz-box-align:start" that I removed.  It was set only in RTL mode, and as far as I could tell it had no effect in phone mode but totally broke the tablet UI.  I'll see if I can figure out why it was added in the first place.

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 561897 [details] [diff] [review]
part 1: Make sidebar dragging work in RTL

I didn't mean to obsolete this.

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e9807475e1e
https://hg.mozilla.org/integration/mozilla-inbound/rev/94852085df97

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1e9807475e1e
https://hg.mozilla.org/mozilla-central/rev/94852085df97

Comment 7

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1