685396 - port bug 568949 (64-bit installer fix) to Seamonkey

Status: RESOLVED FIXED

(SeaMonkey :: Installer, enhancement)

Description

[Makoto Kato [:m_kato] (PTO until May 6)]

Although comm-central supports Win64 build, Seamonkey installer doesn't consider 64-bit package.

Comment 1

[Atsushi Okawa]

Attachment: to make 64-bit installer

This patch is the fix similar to the Firefox one.

Comment 2

[Makoto Kato [:m_kato] (PTO until May 6)]

(In reply to Atsushi Okawa from comment #1)
> Created attachment 569005 [details]
> to make 64-bit installer
> 
> This patch is the fix similar to the Firefox one.

Okawa-san, could you create a new patch for comm-central instead of comm-beta?

Win64 fix should not be landed to aurora and beta.

Comment 3

[Atsushi Okawa]

Attachment: to make 64-bit installer 2

Kato-san
>Win64 fix should not be landed to aurora and beta.
I'm sorry. I don't understand it enough.

I make the patch for comm-central.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 569060 [details] [diff] [review]
to make 64-bit installer 2

I'm behind on reviews, doing some catchup today, but since win64 is low priority for me atm, I'm deferring this for a while, I likely won't get to it until early January (sorry)

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 569060 [details] [diff] [review]
to make 64-bit installer 2

Review of attachment 569060 [details] [diff] [review]:
-----------------------------------------------------------------

I think this looks good, feedback requesting from rstrong just to be sure I am not missing some obvious gotchya in this code.

::: suite/installer/windows/nsis/installer.nsi
@@ -1037,5 @@
> -  IntOp $R8 $R5 + $R6
> -  ; Add 1024 Kb to the diskspace requirement since the installer makes a copy
> -  ; of the MAPI dll's (around 20 Kb)... also, see Bug 434338.
> -  IntOp $R8 $R8 + 1024
> -  SectionSetSize ${APP_IDX} $R8

Please change this section Size stuff to keep that comment and do:
IntOp $R5 $R5 + 1024

Comment 6

[Atsushi Okawa]

Attachment: the patch to make 64bit installer

(In reply to Justin Wood (:Callek) from comment #5)
I made a patch and upload it. I fixed the mistake of previous patch you pointed out.

Comment 7

[Phoenix]

Am I guess right, and you forget to set review request flag after remaking patch?

Comment 8

[Philip Chee]

Comment on attachment 584592 [details] [diff] [review]
the patch to make 64bit installer

> Am I guess right, and you forget to set review request flag after remaking
> patch?
Hmm. First Patch. He might not have editBugs permissions. I'll set it for him.

Thank you very much Atsushi-san!

Comment 9

[Philip Chee]

Comment on attachment 584592 [details] [diff] [review]
the patch to make 64bit installer

Callek said that mcsmurf would also be a suitable reviewer. So whoever gets to this first...

Comment 10

[Justin Wood (:Callek)]

Comment on attachment 584592 [details] [diff] [review]
the patch to make 64bit installer

Review of attachment 584592 [details] [diff] [review]:
-----------------------------------------------------------------

sorry for the delay here.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Landed with some bitrot fixing.
http://hg.mozilla.org/comm-central/rev/c30bddba3513

Thanks for the patch, Atsushi-san! One request - to make life easier for those checking in patches on your behalf, please follow the directions below for any future patches you submit. Thanks again!
https://developer.mozilla.org/en/Creating_a_patch_that_can_be_checked_in

Comment 12

[Atsushi Okawa]

I'm sorry for it.I don't know how to check in c-c.I will read the page.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Not a problem!