Attachment pane width in composer is not consistent

RESOLVED FIXED in Thunderbird 9.0

Status

Thunderbird
Message Compose Window
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: squib, Assigned: squib)

Tracking

8 Branch
Thunderbird 9.0

Thunderbird Tracking Flags

(thunderbird8 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
When you add an attachment to a message and then remove it, the width of the attachment pane shrinks a bit. This is from bug 630759, and the fix should be easy.
(Assignee)

Comment 1

6 years ago
Created attachment 559730 [details] [diff] [review]
Fix this

Here's a fix. I can test this if you feel like it's necessary, but since it's all CSS, I'm not too worried.
Attachment #559730 - Flags: review?(bwinton)
Comment on attachment 559730 [details] [diff] [review]
Fix this

Review of attachment 559730 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm.  Do we really want the attachment pane with nothing in it to be the same size as the attachment pane with stuff in it?  It seems like a lot of space to take up with nothing.  On the other hand, there's probably not going to be a lot of stuff in the From/Cc/Bcc field either...

Okay, I'm going to say that having things not move around in a distracting manner tips the balance towards this change.  ui-r=me, and r=me cause the code is tiny and simple.  ;)

Thanks,
Blake.
Attachment #559730 - Flags: ui-review+
Attachment #559730 - Flags: review?(bwinton)
Attachment #559730 - Flags: review+
(Assignee)

Comment 3

6 years ago
Checked in with a tiny change to the order of the CSS (and making the selector a bit more consistent with its neighbor): http://hg.mozilla.org/comm-central/rev/22dcd4d04ee9
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
(Assignee)

Comment 4

6 years ago
Comment on attachment 559730 [details] [diff] [review]
Fix this

This is, technically, a regression from 7 to 8, so asking for approval on aurora.
Attachment #559730 - Flags: approval-comm-aurora?
Attachment #559730 - Flags: approval-comm-aurora? → approval-comm-aurora+
Transplanted to aurora: http://hg.mozilla.org/releases/comm-aurora/rev/c1fdf33063f2
status-thunderbird8: --- → fixed
You need to log in before you can comment on or make changes to this bug.