685437 - Attachment pane width in composer is not consistent

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Jim Porter (:squib)]

When you add an attachment to a message and then remove it, the width of the attachment pane shrinks a bit. This is from bug 630759, and the fix should be easy.

Comment 1

[Jim Porter (:squib)]

Attachment: Fix this

Here's a fix. I can test this if you feel like it's necessary, but since it's all CSS, I'm not too worried.

Comment 2

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 559730 [details] [diff] [review]
Fix this

Review of attachment 559730 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm.  Do we really want the attachment pane with nothing in it to be the same size as the attachment pane with stuff in it?  It seems like a lot of space to take up with nothing.  On the other hand, there's probably not going to be a lot of stuff in the From/Cc/Bcc field either...

Okay, I'm going to say that having things not move around in a distracting manner tips the balance towards this change.  ui-r=me, and r=me cause the code is tiny and simple.  ;)

Thanks,
Blake.

Comment 3

[Jim Porter (:squib)]

Checked in with a tiny change to the order of the CSS (and making the selector a bit more consistent with its neighbor): http://hg.mozilla.org/comm-central/rev/22dcd4d04ee9

Comment 4

[Jim Porter (:squib)]

Comment on attachment 559730 [details] [diff] [review]
Fix this

This is, technically, a regression from 7 to 8, so asking for approval on aurora.

Comment 5

[Mark Banner (:standard8)]

Transplanted to aurora: http://hg.mozilla.org/releases/comm-aurora/rev/c1fdf33063f2