Closed Bug 685568 Opened 8 years ago Closed 8 years ago

[TABLETUI] add vertical divider between tab bar and web content

Categories

(Firefox for Android Graveyard :: General, defect)

Firefox 9
All
Android
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 9

People

(Reporter: ibarlow, Assigned: lucasr)

References

Details

Attachments

(2 files)

Attached image mockup
This will help tie our tab image and action bar together nicely, particularly with websites that have darker backgrounds.
Assignee: nobody → lucasr.at.mozilla
Blocks: 655762
Depends on: 680077
I considered parametrizing the color of the divider based on toolbar color but this will only make sense if/when we start actually theming tablet mode for gingerbread/froyo. For now, just setting the color that makes sense with our current tablet design.
Attachment #559202 - Flags: review?(mbrubeck)
Attachment #559202 - Flags: review?(mbrubeck) → review+
Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d771ae3d3021
https://hg.mozilla.org/integration/mozilla-inbound/rev/db34d544a36b

(I was experimenting with a change to this patch and forgot to revert it before pushing, so I changed it back in a follow-up push.)
OS: Mac OS X → Android
Hardware: x86 → All
Whiteboard: [inbound]
After consulting with Ian, we actually do want to go with the xxlarge border, so I pushed a *third* change to back out db34d544a36b:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c13a8d2c0cbb
https://hg.mozilla.org/mozilla-central/rev/c13a8d2c0cbb
https://hg.mozilla.org/mozilla-central/rev/db34d544a36b
https://hg.mozilla.org/mozilla-central/rev/d771ae3d3021
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.