Closed
Bug 685878
Opened 13 years ago
Closed 13 years ago
Cache the sidebar width in ViewableAreaObserver
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 686417
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Keywords: perf)
Attachments
(1 file)
1.31 KB,
patch
|
mbrubeck
:
review-
|
Details | Diff | Splinter Review |
This will save some work each time we call ViewableAreaObserver.width.
Attachment #559471 -
Flags: review?(mark.finkle)
Updated•13 years ago
|
Attachment #559471 -
Flags: review?(mark.finkle) → review+
Comment 1•13 years ago
|
||
Wait, won't this need to change when we support portrait mode and it's hidden sidebar?
Comment 2•13 years ago
|
||
I guess we could set the tabletSidebarWidth to null when we sense a rotation
Assignee | ||
Comment 3•13 years ago
|
||
Comment on attachment 559471 [details] [diff] [review] patch Good point.
Attachment #559471 -
Flags: review+ → review-
Assignee | ||
Comment 4•13 years ago
|
||
This is fixed by one of the patches in bug 686417.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•