Last Comment Bug 686032 - Test for bug 622088 conceals its location after it's done
: Test for bug 622088 conceals its location after it's done
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla9
Assigned To: :Ehsan Akhgari (busy, don't ask for review please)
:
Mentors:
Depends on:
Blocks: 622088 668728
  Show dependency treegraph
 
Reported: 2011-09-09 15:21 PDT by :Ehsan Akhgari (busy, don't ask for review please)
Modified: 2011-09-23 20:47 PDT (History)
3 users (show)
ehsan: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (1.61 KB, patch)
2011-09-09 15:41 PDT, :Ehsan Akhgari (busy, don't ask for review please)
ted: review+
justin.lebar+bug: review+
Details | Diff | Review

Description :Ehsan Akhgari (busy, don't ask for review please) 2011-09-09 15:21:45 PDT
My patch in bug 668728 requires that when each test is finished, its location won't change.  The test for bug 622088 breaks this invariant, by using history.replaceState.  I have a simple patch to fix this.
Comment 1 :Ehsan Akhgari (busy, don't ask for review please) 2011-09-09 15:41:51 PDT
Created attachment 559603 [details] [diff] [review]
Patch (v1)
Comment 2 Ted Mielczarek [:ted.mielczarek] 2011-09-23 07:05:19 PDT
Comment on attachment 559603 [details] [diff] [review]
Patch (v1)

Review of attachment 559603 [details] [diff] [review]:
-----------------------------------------------------------------

Fine, but again, I'd really prefer the original test authors to r+ these.
Comment 3 Justin Lebar (not reading bugmail) 2011-09-23 07:14:19 PDT
Copy-pasted from bug 685788 comment 3:

(In reply to Ehsan Akhgari [:ehsan] from comment #0)
> My patch in bug 668728 requires that when each test is finished, its
> location won't change.

It's not a problem if the test fails (e.g. throws an exception) and leaves the location different than it was initially?

ed. to add: The failure mode for many of these tests is to hang and not get to the SimpleTest.finish() call.
Comment 4 :Ehsan Akhgari (busy, don't ask for review please) 2011-09-23 12:51:08 PDT
(In reply to Justin Lebar [:jlebar] from comment #3)
> Copy-pasted from bug 685788 comment 3:
> 
> (In reply to Ehsan Akhgari [:ehsan] from comment #0)
> > My patch in bug 668728 requires that when each test is finished, its
> > location won't change.
> 
> It's not a problem if the test fails (e.g. throws an exception) and leaves
> the location different than it was initially?
> 
> ed. to add: The failure mode for many of these tests is to hang and not get
> to the SimpleTest.finish() call.

That should be fine, as my patch in bug 668728 would catch that as an explicit failure.  So we'll have one timeout, and one explicit failure.  Which is even better than only a timeout.  ;-)
Comment 5 Justin Lebar (not reading bugmail) 2011-09-23 12:54:54 PDT
Comment on attachment 559603 [details] [diff] [review]
Patch (v1)

Cool; sounds like a plan!
Comment 6 :Ehsan Akhgari (busy, don't ask for review please) 2011-09-23 13:30:09 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd648ccf5f96
Comment 7 Ed Morley [:emorley] 2011-09-23 20:47:16 PDT
https://hg.mozilla.org/mozilla-central/rev/cd648ccf5f96

Note You need to log in before you can comment on or make changes to this bug.