The default bug view has changed. See this FAQ.

Test for bug 622088 conceals its location after it's done

RESOLVED FIXED in mozilla9

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla9
x86
Mac OS X
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.61 KB, patch
ted
: review+
Justin Lebar (not reading bugmail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
My patch in bug 668728 requires that when each test is finished, its location won't change.  The test for bug 622088 breaks this invariant, by using history.replaceState.  I have a simple patch to fix this.
(Assignee)

Comment 1

6 years ago
Created attachment 559603 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #559603 - Flags: review?(ted.mielczarek)
Comment on attachment 559603 [details] [diff] [review]
Patch (v1)

Review of attachment 559603 [details] [diff] [review]:
-----------------------------------------------------------------

Fine, but again, I'd really prefer the original test authors to r+ these.
Attachment #559603 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

6 years ago
Attachment #559603 - Flags: review?(justin.lebar+bug)
Copy-pasted from bug 685788 comment 3:

(In reply to Ehsan Akhgari [:ehsan] from comment #0)
> My patch in bug 668728 requires that when each test is finished, its
> location won't change.

It's not a problem if the test fails (e.g. throws an exception) and leaves the location different than it was initially?

ed. to add: The failure mode for many of these tests is to hang and not get to the SimpleTest.finish() call.
(Assignee)

Comment 4

6 years ago
(In reply to Justin Lebar [:jlebar] from comment #3)
> Copy-pasted from bug 685788 comment 3:
> 
> (In reply to Ehsan Akhgari [:ehsan] from comment #0)
> > My patch in bug 668728 requires that when each test is finished, its
> > location won't change.
> 
> It's not a problem if the test fails (e.g. throws an exception) and leaves
> the location different than it was initially?
> 
> ed. to add: The failure mode for many of these tests is to hang and not get
> to the SimpleTest.finish() call.

That should be fine, as my patch in bug 668728 would catch that as an explicit failure.  So we'll have one timeout, and one explicit failure.  Which is even better than only a timeout.  ;-)
Comment on attachment 559603 [details] [diff] [review]
Patch (v1)

Cool; sounds like a plan!
Attachment #559603 - Flags: review?(justin.lebar+bug) → review+
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd648ccf5f96
Flags: in-testsuite+
Target Milestone: --- → mozilla9
https://hg.mozilla.org/mozilla-central/rev/cd648ccf5f96
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.