686051 - What to do when the transaction goes wrong

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Description

[Andy McKay]

We've assumed a straight flow through to buying an addon or webapp that ends up at the thank you page. But that assumes paypal returns a 'COMPLETED' status when we check with PayPal that its been purchased.

But PayPal could come back with 'INCOMPLETE', 'CREATED', 'ERROR', 'EXPIRED' or 'PROCESSING'.

Error is easy, we need to show a nice error.

The others are little more tricky, should we poll the server until they work?

Either way, the addon / webapp should not be installed afterwards. This ticket is for making sure the front end copes correctly.

Comment 1

[Andy McKay]

Let's just cope with showing an error in this issue. Should just be a matter of altering the template shown back in paypal_thanks.

Comment 2

[Andy McKay]

PROCESSING can be ignored. We are blocking payments that might produce this on the paypal end.

Comment 3

[Gregory Koberger (:gkoberger)]

Andy, did we decide on polling? So, if we get "ERROR", we show an error. Anything else on the list, we poll until we get the right thing?

And since I don't even know where to start looking, what URL should I be polling? A paypal one? Or a Mozilla one?

Comment 4

[Andy McKay]

We are blocking any payments that result in pending. So you'll either get a pass or a fail there are no other conditions to worry about. You don't need to ping or poll paypal, theoretically the error will get passed into the template in purchase_complete.

Comment 5

[Gregory Koberger (:gkoberger)]

Code is written, but I can't figure out how to force PayPal to return an error so I can see if it actually works. Krupa? Andy?

Comment 6

[Andy McKay]

I don't know either. I do know that if you break the code and make it return an error, we can test then. It seems odd but that could become a waffle flag: break paypal. The problem is that as I understand it, the sandbox is pretty forgiving in and allows all things to work.

Comment 7

[Gregory Koberger (:gkoberger)]

https://github.com/gkoberger/zamboni/commit/a34e5a3