Calling openURL on an uninitialized nsIMessenger crashes TB
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Tracking
(Not tracked)
People
(Reporter: benjamin.lerner, Unassigned)
Details
(Keywords: crash, reproducible, testcase, Whiteboard: [rare])
Crash Data
Attachments
(2 files, 2 obsolete files)
Updated•13 years ago
|
Updated•13 years ago
|
Comment 1•13 years ago
|
||
Updated•13 years ago
|
Comment 2•13 years ago
|
||
Reporter | ||
Comment 3•13 years ago
|
||
Comment 4•13 years ago
|
||
Reporter | ||
Comment 5•13 years ago
|
||
Comment 6•13 years ago
|
||
Comment 7•13 years ago
|
||
Comment 8•9 years ago
|
||
Updated•9 years ago
|
Comment 9•6 years ago
|
||
Ben, can you still reproduce or still have the addon which caused this?
Still rare, average only one per week
bp-51e724f2-db60-403e-a968-262a10190506
0 xul.dll nsMessenger::AddMsgUrlToNavigateHistory(nsTSubstring<char> const&) comm/mailnews/base/src/nsMessenger.cpp:442 context
1 xul.dll nsMessenger::OpenURL(nsTSubstring<char> const&) comm/mailnews/base/src/nsMessenger.cpp:471 cfi
2 xul.dll nsMsgDBView::LoadMessageByViewIndex(unsigned int) comm/mailnews/base/src/nsMsgDBView.cpp:1228 cfi
3 xul.dll nsMsgGroupView::LoadMessageByViewIndex(unsigned int) comm/mailnews/base/src/nsMsgGroupView.cpp:1056 cfi
4 xul.dll nsMsgDBView::SelectionChanged() comm/mailnews/base/src/nsMsgDBView.cpp:1321 cfi
5 xul.dll NS_InvokeByIndex xpcom/reflect/xptcall/md/win32/xptcinvoke_asm_x86_msvc.asm:54 cfi
Reporter | ||
Comment 10•6 years ago
|
||
Yes -- :protz' addon attached above instantly crashes TB60.6.1. I just installed it, ran it, and submitted a crash trace.
Comment 11•6 years ago
|
||
Thanks. So bp-2bb4ac11-dc15-4380-a7b8-4504d0190512 2019-05-12 15:39:22 and bp-9786f305-2d9e-44d3-9272-23bf60190512
I missed that we have the add-on attached - and so a testcase!
Does this put the finger on the cause?
Updated•5 years ago
|
Updated•4 years ago
|
Comment 12•3 years ago
|
||
The testcase addon won't install - manifest?
Comment 13•3 years ago
|
||
Updated version of the crasher add-on. It adds a browser_action_button "Crash Me" to Thunderbirds main toolbar.
You should restart TB once after installing the add-on, because crashing TB directly removed the button from the toolbar for me (maybe some xulstore has not finished saving the new icon before the crash happend).
Updated•2 years ago
|
Comment 14•1 year ago
|
||
Does this still crash?
There are no reports on crash-stats.
Reporter | ||
Comment 15•10 months ago
|
||
Is there an updated version of the extension to the new manifest format? (I haven't kept up with how to write extensions any more, sorry!)
Updated•10 months ago
|
Comment 16•10 months ago
|
||
Updated version (v3) runs in TB115+ and does not crash.
Comment 17•10 months ago
|
||
Wayne, how should we move this forward? We usually do not add tests for Experiment code, and Thunderbird itself does not cause this crash.
Thunderbird does not even use this function anymore:
https://searchfox.org/comm-central/search?q=.openUrl%28&path=&case=false®exp=false
For me, this entire bug is invalid by now. We provide all the different ways to open tabs/windows/messages through WebExtension APIs.
Updated•8 months ago
|
Description
•