Closed Bug 686170 Opened 8 years ago Closed 8 years ago

Remove modules/zlib/standalone

Categories

(Core :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla9

People

(Reporter: matjk7, Assigned: emorley)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Flags: in-testsuite-
Attached patch Patch v1 (obsolete) — Splinter Review
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #560024 - Flags: review?(joe)
In fact, isn't this still needed for the installer? ie:
http://mxr.mozilla.org/mozilla-central/source/toolkit/toolkit-tiers.mk#80
Attachment #560024 - Attachment is obsolete: true
Attachment #560024 - Flags: review?(joe)
(In reply to Ed Morley [:edmorley] from comment #2)
> In fact, isn't this still needed for the installer? ie:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/toolkit-tiers.mk#80

Well that sucks. Ted might know if it's really needed.
I bet that's a lie. Rob: we don't actually use libjar/zlib in the installer anymore, right?
Considering that standalone libjar doesn't exist anymore (bug 505784), it's probably a lie.
Attached patch Patch v2Splinter Review
Ah, in which case I presume this can come out after all then. 

Updated patch for toolkit-tiers.mk and toolkit-makefiles.sh changes. Builds fine locally, sent to try:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=f0f350512b05
Attachment #560142 - Flags: review?(ted.mielczarek)
(In reply to Ted Mielczarek [:ted, :luser] from comment #4)
> I bet that's a lie. Rob: we don't actually use libjar/zlib in the installer
> anymore, right?
Not for the desktop installer and that was probably for the win mobile installer... you should check with someone on the mobile team since they are more familiar with whether they plan on using it in the future.
CCing some mobile people for comment 7. Thanks :-)
Attachment #560142 - Flags: review?(ted.mielczarek) → review+
(In reply to Ed Morley [:edmorley] from comment #8)
> CCing some mobile people for comment 7. Thanks :-)

This was only used for the Windows Mobile installer. Removing won't affect mobile.
Thanks Mark :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/eafaff0efeef
Target Milestone: --- → mozilla9
https://hg.mozilla.org/mozilla-central/rev/eafaff0efeef
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.