Remove modules/zlib/standalone

RESOLVED FIXED in mozilla9

Status

()

Core
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Matheus Kerschbaum, Assigned: emorley)

Tracking

Trunk
mozilla9
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 560024 [details] [diff] [review]
Patch v1
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #560024 - Flags: review?(joe)
(Assignee)

Comment 2

6 years ago
In fact, isn't this still needed for the installer? ie:
http://mxr.mozilla.org/mozilla-central/source/toolkit/toolkit-tiers.mk#80
(Assignee)

Updated

6 years ago
Attachment #560024 - Attachment is obsolete: true
Attachment #560024 - Flags: review?(joe)
(Reporter)

Comment 3

6 years ago
(In reply to Ed Morley [:edmorley] from comment #2)
> In fact, isn't this still needed for the installer? ie:
> http://mxr.mozilla.org/mozilla-central/source/toolkit/toolkit-tiers.mk#80

Well that sucks. Ted might know if it's really needed.
I bet that's a lie. Rob: we don't actually use libjar/zlib in the installer anymore, right?
(Reporter)

Comment 5

6 years ago
Considering that standalone libjar doesn't exist anymore (bug 505784), it's probably a lie.
(Assignee)

Comment 6

6 years ago
Created attachment 560142 [details] [diff] [review]
Patch v2

Ah, in which case I presume this can come out after all then. 

Updated patch for toolkit-tiers.mk and toolkit-makefiles.sh changes. Builds fine locally, sent to try:
https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=f0f350512b05
(Assignee)

Updated

6 years ago
Attachment #560142 - Flags: review?(ted.mielczarek)
(In reply to Ted Mielczarek [:ted, :luser] from comment #4)
> I bet that's a lie. Rob: we don't actually use libjar/zlib in the installer
> anymore, right?
Not for the desktop installer and that was probably for the win mobile installer... you should check with someone on the mobile team since they are more familiar with whether they plan on using it in the future.
(Assignee)

Comment 8

6 years ago
CCing some mobile people for comment 7. Thanks :-)
Attachment #560142 - Flags: review?(ted.mielczarek) → review+
(In reply to Ed Morley [:edmorley] from comment #8)
> CCing some mobile people for comment 7. Thanks :-)

This was only used for the Windows Mobile installer. Removing won't affect mobile.
(Assignee)

Comment 10

6 years ago
Thanks Mark :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/eafaff0efeef
Target Milestone: --- → mozilla9
https://hg.mozilla.org/mozilla-central/rev/eafaff0efeef
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.