Closed
Bug 686170
Opened 13 years ago
Closed 13 years ago
Remove modules/zlib/standalone
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla9
People
(Reporter: matjk7, Assigned: emorley)
Details
Attachments
(1 file, 1 obsolete file)
4.26 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
Assignee | ||
Comment 1•13 years ago
|
||
Assignee | ||
Comment 2•13 years ago
|
||
In fact, isn't this still needed for the installer? ie: http://mxr.mozilla.org/mozilla-central/source/toolkit/toolkit-tiers.mk#80
Assignee | ||
Updated•13 years ago
|
Attachment #560024 -
Attachment is obsolete: true
Attachment #560024 -
Flags: review?(joe)
Reporter | ||
Comment 3•13 years ago
|
||
(In reply to Ed Morley [:edmorley] from comment #2) > In fact, isn't this still needed for the installer? ie: > http://mxr.mozilla.org/mozilla-central/source/toolkit/toolkit-tiers.mk#80 Well that sucks. Ted might know if it's really needed.
Comment 4•13 years ago
|
||
I bet that's a lie. Rob: we don't actually use libjar/zlib in the installer anymore, right?
Reporter | ||
Comment 5•13 years ago
|
||
Considering that standalone libjar doesn't exist anymore (bug 505784), it's probably a lie.
Assignee | ||
Comment 6•13 years ago
|
||
Ah, in which case I presume this can come out after all then. Updated patch for toolkit-tiers.mk and toolkit-makefiles.sh changes. Builds fine locally, sent to try: https://tbpl.mozilla.org/?tree=Try&usebuildbot=1&rev=f0f350512b05
Assignee | ||
Updated•13 years ago
|
Attachment #560142 -
Flags: review?(ted.mielczarek)
Comment 7•13 years ago
|
||
(In reply to Ted Mielczarek [:ted, :luser] from comment #4) > I bet that's a lie. Rob: we don't actually use libjar/zlib in the installer > anymore, right? Not for the desktop installer and that was probably for the win mobile installer... you should check with someone on the mobile team since they are more familiar with whether they plan on using it in the future.
Updated•13 years ago
|
Attachment #560142 -
Flags: review?(ted.mielczarek) → review+
Comment 9•13 years ago
|
||
(In reply to Ed Morley [:edmorley] from comment #8) > CCing some mobile people for comment 7. Thanks :-) This was only used for the Windows Mobile installer. Removing won't affect mobile.
Assignee | ||
Comment 10•13 years ago
|
||
Thanks Mark :-) https://hg.mozilla.org/integration/mozilla-inbound/rev/eafaff0efeef
Target Milestone: --- → mozilla9
Comment 11•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/eafaff0efeef
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•