Closed Bug 686186 Opened 13 years ago Closed 8 years ago

[OS/2] crash in font matching code

Categories

(Core :: Graphics, defect)

x86
OS/2
defect
Not set
critical

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: stevew, Assigned: dave.r.yeo)

References

()

Details

(Keywords: crash)

Crash Data

Attachments

(2 files)

Some web pages trigger crashes in the OS/2 font matching code; started seeing this with Gecko 6.  SourceForge pages sometimes trigger this, but not always.
Severity: normal → critical
Keywords: crash
Weird that this doesn't show any OS/2 functions involved in the crash.
(In reply to Peter Weilbacher from comment #1)
> Weird that this doesn't show any OS/2 functions involved in the crash.

Yet it was a very consistent crash. Anyways with SeaMonkey 2.4 (undistributed) both of Steve's test cases stopped crashing but sourceforge download pages still crashed.
With SeaMonkey 2.5 I haven't seen this crash and finally downloaded the file from sourceforge that I couldn't previously. I also just went through all the crash reports at crash@e-vertise.com and there were none of these.
Since FF6 is depreciated anyways I suggest that Steve close this as worksforme, we can always reopen.
The URL in the URL field still causes the crash here, in 2.5.  I could change the version to 8 branch, if that makes you feel better.
(In reply to Steve Wendt from comment #3)
> The URL in the URL field still causes the crash here, in 2.5.  I could
> change the version to 8 branch, if that makes you feel better.

It crashes for me with 2.5 and 2.7a1. Perhaps it was just coincidence that 2.4 worked or perhaps due to my building against klibc064, have to test as we need to find what's broken or at least different in 6.4 anyways.
Assignee: nobody → daveryeo
Status: NEW → ASSIGNED
Version: 6 Branch → unspecified
Hmm, with the TRP files in the dupe I looked at the code again and I see various possibilities for NULL pointers that could cause such crashes. But without being able to actually debug the code (stepping through it in the debugger or adding printfs), I don't think I can deduce where to take a closer look.
It seems I get the same trap with the new Seamonkey on Netlabs with this URL
http://www.hth.dk/Find-Butik

trap attached
Attached file Execptq trap
Crash Signature: [@ gfxPlatformFontList::FindFontForFamily]
Workaround posted in the newsgroup: setting gfx.downloadable_fonts.enabled to false prevents the crashes.
Workaround confirmed here on Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.2) Gecko/20120216 Firefox/10.0.2 SeaMonkey/2.7 ID:20120216144140.

I don't exactly know which urls might have triggered this for me (I'll have to review my collection of .trp files, I guess), but Allan's test url in comment 7 crashed as soon as the map displayed (before setting this pref), and now it does not crash.

Thanks to Len Small for posting this workaround in the group, and to you, Steve, for following up, here.
Apparently the work around isn't the silver bullet I was hoping for. It still crashes doing something with fonts since the next opening of FFox comes up with messed up fonts. Closing and reopening FFox solves the messed up fonts. The only data I can find is in the Popuplog.os2 which I will copy below.

03-26-2012  21:36:53  SYS3175  PID 0062  TID 0019  Slot 00d3
E:\FFOX10\FIREFOX10.EXE
c0000005
1d08c034
P1=00000001  P2=00000014  P3=XXXXXXXX  P4=XXXXXXXX
EAX=00000001  EBX=03a70000  ECX=00190062  EDX=13e8af20
ESI=1ce70394  EDI=00004000
DS=0053  DSACC=f0f3  DSLIM=ffffffff
ES=0053  ESACC=f0f3  ESLIM=ffffffff
FS=150b  FSACC=00f3  FSLIM=00000030
GS=0000  GSACC=****  GSLIM=********
CS:EIP=005b:1d08c034  CSACC=f0df  CSLIM=ffffffff
SS:ESP=0053:03b80eac  SSACC=f0f3  SSLIM=ffffffff
EBP=03b80ef4  FLG=00010206

KERNEL32.DLL 0001:0000c034

------------------------------------------------------------

03-26-2012  21:40:53  SYS3175  PID 0086  TID 0018  Slot 00d9
E:\FFOX10\FIREFOX10.EXE
c0000005
1d05c034
P1=00000001  P2=00000014  P3=XXXXXXXX  P4=XXXXXXXX
EAX=00000001  EBX=03920000  ECX=00180086  EDX=13e8af20
ESI=1cec0394  EDI=00004000
DS=0053  DSACC=f0f3  DSLIM=ffffffff
ES=0053  ESACC=f0f3  ESLIM=ffffffff
FS=150b  FSACC=00f3  FSLIM=00000030
GS=0000  GSACC=****  GSLIM=********
CS:EIP=005b:1d05c034  CSACC=f0df  CSLIM=ffffffff
SS:ESP=0053:03a30eac  SSACC=f0f3  SSLIM=ffffffff
EBP=03a30ef4  FLG=00010206

KERNEL32.DLL 0001:0000c034
(In reply to Cliff Scott from comment #11)
> Apparently the work around isn't the silver bullet I was hoping for. It
> still crashes doing something with fonts since the next opening of FFox
> comes up with messed up fonts. Closing and reopening FFox solves the messed
> up fonts. The only data I can find is in the Popuplog.os2 which I will copy
> below.
> 
> 03-26-2012  21:36:53  SYS3175  PID 0062  TID 0019  Slot 00d3
> E:\FFOX10\FIREFOX10.EXE
[...]
> 
> KERNEL32.DLL 0001:0000c034

Kernel32.dll is part of Odin. Are you using Flash? If so try disabling it and see if you get the same crash. Also make sure you're using the latest Odin and Flash.
Yes, I am using flash and that page was trying to load flash content although I have the Flashblock extension active so I was assuming, apparently falsely, that flash would not be running yet. I am using the latest Odin 0.8.4 and the latest Flash 10, but not the new Flash 11 beta.

Renaming the flash dlls in FFox allowed the page to load so even though it looked to me like a font issue I suppose it is more of a flash issue.

Offending URL: http://holdredgeenterprises.com/Demos/demos.html
Cliff, it's generally a good idea (and I know that you know this - consider this a memo for anyone else posting in this bug or similar ones) to disable extensions and plugins (*or*, better yet, create a fresh profile with the default theme) whenever testing what appears to be a consistently failing (read: crashing) url.

And, as Dave pointed out, look for signs of non-native modules in POPUPLOG.OS2 (such as KERNEL32.DLL, which is a Win32 module), vs something like DOSCALL1.DLL, for example.

Final thought (and apologies to all for the bugspam): uninstall Flash 10 and install Flash 11 ASAP. The stability difference is palpable.
I was not aware that kernel32.dll was a Win32 module.

FYI, the crashing of FFox 10 with Flash 10 was because of the Odin 0.8.4 update. Rolling back to 0,8.3 solved the crashing on that site as well as others that used to work fine. I would like to update to Flash 11, but don't have a current Software Subscription.
Cliff, you should probably file a bug against Odin and/or perhaps Flash as I doubt you're the only one still running Flash 10.
Steve, does this crash still reproduce?
Flags: needinfo?(stevew)
Works for me, now that web-fonts have been enabled:

User agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:38.0) Gecko/20100101 Firefox/38.0 SeaMonkey/2.35
Build identifier: 20160506215452
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: needinfo?(stevew)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.