686380 - [Tablet] "Undo close tab" thumbnail stays around too long

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

In the phone UI, the "undo close tab" thumbnail goes away when the sidebar is dismissed.  Since you can't dismiss the sidebar in the tablet UI, the thumbnail just sticks around indefinitely.  We should make it disappear at some point.

Here are some situations where we could choose to make it disappear:

* User opens a new tab
* User switches tabs
* User navigates to a new page in an open tab
* User takes some explicit action to clear the "undo" thumbnail
* Ten minutes (or whatever) has elapsed

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This removes the closed tab thumbnail when:
* User switches tabs
* User opens a new tab
* User navigates to a new page using the location bar

I also considered closing it whenever the user navigates from one page to another (by clicking a link, for example) but since location changes so frequently and are not always user-initiated, so I thought this might cause the closed tab thumbnail to disappear too soon or too unexpectedly.

Any comments from the UX team?

Comment 2

[Matt Brubeck (:mbrubeck)]

(In reply to Matt Brubeck (:mbrubeck) from comment #1)
> Any comments from the UX team?

Madhava says yes, we should try out this patch.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 560000 [details] [diff] [review]
patch


>   selectTab: function selectTab(aTab) {
>     AwesomeScreen.activePanel = null;
>     Browser.selectedTab = aTab;
>+    Elements.tabList.removeClosedTab();
>   },

Maybe this would be better in _tabSelect, since any code could set Browser.selectedTab to something.

r+, but I think we should consider the above

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/0a6d1368cd97

(In reply to Mark Finkle (:mfinkle) from comment #3)
> Maybe this would be better in _tabSelect, since any code could set
> Browser.selectedTab to something.

_tabSelect gets called too often - for example, when you close a tab it causes another tab to get selected, but we don't want to remove the closed tab thumbnail *right* after you close it.

Comment 5

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1