Last Comment Bug 686449 - Make ProcessingInstruction inherit from CharacterData
: Make ProcessingInstruction inherit from CharacterData
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: ---
Assigned To: Olli Pettay [:smaug]
: Andrew Overholt [:overholt]
Depends on: 888864
Blocks: 888672
  Show dependency treegraph
Reported: 2011-09-13 06:39 PDT by Anne (:annevk)
Modified: 2013-07-01 09:38 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (8.32 KB, patch)
2011-09-14 15:47 PDT, Olli Pettay [:smaug]
jonas: review+
Details | Diff | Splinter Review

Description Anne (:annevk) 2011-09-13 06:39:31 PDT
We changed DOM4 so that ProcessingInstruction is much more like Text and Comment.
Comment 1 Olli Pettay [:smaug] 2011-09-14 15:47:45 PDT
Created attachment 560267 [details] [diff] [review]

uploaded to try
Comment 2 Olli Pettay [:smaug] 2011-09-19 22:57:55 PDT
Comment 3 :Gijs Kruitbosch 2013-06-30 17:00:02 PDT
This seems to have regressed updating the contents of a PI and having that restyle the document - but re-inserting the PI after changing its contents offers a workaround. Is this expected behaviour (maybe the API we're supposed to use changed?), or should I file a bug to fix this in core? See bug 888672 for more details and easy STR.
Comment 4 :Ms2ger (⌚ UTC+1/+2) 2013-07-01 00:08:30 PDT
Please file a bug. It seems that it might be caused by pi->SetData now calling nsGenericDOMDataNode::SetData -> SetTextInternal directly rather than SetNodeValue -> SetNodeValueInternal which XMLStylesheetProcessingInstruction overrides.
Comment 5 Olli Pettay [:smaug] 2013-07-01 03:44:14 PDT
Yes, new bug please.

Note You need to log in before you can comment on or make changes to this bug.