Closed Bug 686449 Opened 8 years ago Closed 8 years ago

Make ProcessingInstruction inherit from CharacterData

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: annevk, Assigned: smaug)

References

Details

Attachments

(1 file)

We changed DOM4 so that ProcessingInstruction is much more like Text and Comment.
Assignee: nobody → Olli.Pettay
Attached patch patchSplinter Review
uploaded to try
Attachment #560267 - Flags: review?(jonas)
https://hg.mozilla.org/mozilla-central/rev/f7cbb2d9c61d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Blocks: 888672
This seems to have regressed updating the contents of a PI and having that restyle the document - but re-inserting the PI after changing its contents offers a workaround. Is this expected behaviour (maybe the API we're supposed to use changed?), or should I file a bug to fix this in core? See bug 888672 for more details and easy STR.
Flags: needinfo?(bugs)
Please file a bug. It seems that it might be caused by pi->SetData now calling nsGenericDOMDataNode::SetData -> SetTextInternal directly rather than SetNodeValue -> SetNodeValueInternal which XMLStylesheetProcessingInstruction overrides.
Flags: needinfo?(bugs)
Yes, new bug please.
Blocks: 888864
No longer blocks: 888864
Depends on: 888864
You need to log in before you can comment on or make changes to this bug.