888672 - changing motif doesn't change the style for the tree objects

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Robert Utasi [:hunboy]]

When we change motif manually, the userlist and the channel-tree plugin treebox style doesn't change. At startup it works. Current known workaround is restart the chatzilla with the new motif.

The last good mozilla-central is 2011-09-20
The first bad mozilla-central is 2011-09-21
http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=2011-09-20&enddate=2011-09-21

I've tried the clearStyleAndImageCaches() function on the treebox but no effect.

Comment 1

[Robert Utasi [:hunboy]]

I forgot: /sync stuffs also have no effect for it. But this can be a possible way, resyncing somehow the treeobjects.

However channel-tree is currently not part of chatzilla, but would be good to find some general fix which one doesn't require plugin-patch. The channel-tree plugin is motif-compatible at this moment.

Comment 2

[Szabolcs Hubai (:xabolcs)]

If I reinsert "dyn-motif" named CSS (after changing motif), then it gets applied.

Comment 3

[Robert Utasi [:hunboy]]

Attachment: reappend motif at sync-motif

Based on Szabi's idea I reappend the node, i think it's acceptable workaround while sync-output is more hardcoded than this.

Comment 4

[James Ross]

Comment on attachment 769515 [details] [diff] [review]
reappend motif at sync-motif

Review of attachment 769515 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome hack, well done! Code is fine as it is. r=silver

Comment 5

[:Gijs (he/him)]

http://hg.mozilla.org/chatzilla/rev/f89c876daa94

Thanks!

Comment 6

[Robert Utasi [:hunboy]]

xabolcs++

for the hint :)

http://james-ross.co.uk/mozilla/chatzilla/nightly/builds/0.9.90/2013070100/chatzilla-0.9.90-2013070100.xpi

Comment 7

[:Gijs (he/him)]

So, checking nightlies again, this regressed between:

http://hg.mozilla.org/mozilla-central/rev/648d084ca28e (good)

and

http://hg.mozilla.org/mozilla-central/rev/e8bd19f6abbb (bad)

on m-c.

This says:

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=648d084ca28e&tochange=e8bd19f6abbb

Which suddenly includes bug 686449 and all is clear...