686530 - Refresh button's selected state cover the urlbar lines

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Lucas Rocha (:lucasr)]

Attachment: Screenshot

See screenshot.

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Fix padding on icons to not cover urlbar line

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 560604 [details] [diff] [review]
Fix padding on icons to not cover urlbar line

Review of attachment 560604 [details] [diff] [review]:
-----------------------------------------------------------------

You'll need to adjust this for rtl mode as well. Either add a line underneith, or better set padding-bottom and -moz-padding-end

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Fix padding on icons to not cover urlbar line

Used padding-bottom and -moz-padding-end as suggested. Keeping the review+.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e807121f9e0

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Why pixels (px) and not mozmm ?

Comment 6

[Wesley Johnston (:wesj)]

The offset here needs to ensure that the buttons aren't covering the background image which is one pixel wide/tall, regardless of what OS it is running on.

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8e807121f9e0

Comment 8

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1