Closed
Bug 686530
Opened 13 years ago
Closed 13 years ago
Refresh button's selected state cover the urlbar lines
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 9
People
(Reporter: lucasr, Assigned: lucasr)
References
Details
Attachments
(2 files, 1 obsolete file)
|
3.34 KB,
image/png
|
Details | |
|
1.06 KB,
patch
|
lucasr
:
review+
|
Details | Diff | Splinter Review |
Screenshot
See screenshot.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → lucasr.at.mozilla
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #560604 -
Flags: review?(wjohnston)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 560604 [details] [diff] [review]
Fix padding on icons to not cover urlbar line
Review of attachment 560604 [details] [diff] [review]:
-----------------------------------------------------------------
You'll need to adjust this for rtl mode as well. Either add a line underneith, or better set padding-bottom and -moz-padding-end
Attachment #560604 -
Flags: review?(wjohnston) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Used padding-bottom and -moz-padding-end as suggested. Keeping the review+.
Attachment #560604 -
Attachment is obsolete: true
Attachment #560618 -
Flags: review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Why pixels (px) and not mozmm ?
|
|
||
Comment 6•13 years ago
|
||
The offset here needs to ensure that the buttons aren't covering the background image which is one pixel wide/tall, regardless of what OS it is running on.
|
|
||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 8•13 years ago
|
||
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•