Closed Bug 686530 Opened 8 years ago Closed 8 years ago

Refresh button's selected state cover the urlbar lines

Categories

(Firefox for Android Graveyard :: General, defect)

All
Android
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 9

People

(Reporter: lucasr, Assigned: lucasr)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image Screenshot
See screenshot.
Blocks: 655762
Assignee: nobody → lucasr.at.mozilla
Attachment #560604 - Flags: review?(wjohnston)
Comment on attachment 560604 [details] [diff] [review]
Fix padding on icons to not cover urlbar line

Review of attachment 560604 [details] [diff] [review]:
-----------------------------------------------------------------

You'll need to adjust this for rtl mode as well. Either add a line underneith, or better set padding-bottom and -moz-padding-end
Attachment #560604 - Flags: review?(wjohnston) → review+
Used padding-bottom and -moz-padding-end as suggested. Keeping the review+.
Attachment #560604 - Attachment is obsolete: true
Attachment #560618 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e807121f9e0
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → Firefox 9
Why pixels (px) and not mozmm ?
The offset here needs to ensure that the buttons aren't covering the background image which is one pixel wide/tall, regardless of what OS it is running on.
https://hg.mozilla.org/mozilla-central/rev/8e807121f9e0
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.