686574 - Inaccurate error message when webapp fails validation due to invalid widget height

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P4)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://addons-dev.allizom.org/z/en-US/developers/apps/submit/2
2. Enter the URL for a webapp with invalid widget height (set to 2000) or load https://people.mozilla.com/~kraj/test-files/webapps/webapp_with_invalid_widget_height.webapp
3. Notice the error message with which validation fails


expected behavior:
Error message is something like "Value of one of the properties in the webapp manifest exceeds the max allowed limit".

actual behavior:
Error message says "Your app failed validation with undefined error." See screenshot.

Comment 1

[Wil Clouser [:clouserw]]

This seems kumarish only because he has the most experience and I'm guessing it's something simple.  Hope so. :)

Comment 2

[Kumar McMillan [:kumar]]

yep, I can take this

Comment 3

[Christopher Van Wiemeersch [:cvan]]

    App: Widget size invalid.
    Apps: App must allow installs from Marketplace for inclusion.

We should not say "App" or "Apps"

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/5902e78

Comment 5

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni-lib/commit/f5ea898b
https://github.com/mozilla/amo-validator/commit/f096f053

Comment 6

[krupa raj[:krupa]]

Thanks for fixing this. Alas, widgets have been removed from the manifest.

I filed bug 748030