Last Comment Bug 686684 - The debugger UI should remember its size across sessions
: The debugger UI should remember its size across sessions
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Victor Porof [:vporof][:vp]
:
Mentors:
Depends on:
Blocks: minotaur
  Show dependency treegraph
 
Reported: 2011-09-14 09:14 PDT by Panos Astithas [:past]
Modified: 2011-10-03 10:19 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
UI height preferences + tests (12.30 KB, patch)
2011-10-03 00:19 PDT, Victor Porof [:vporof][:vp]
no flags Details | Diff | Review
UI height preferences + tests + minor changes in debugger-view (13.65 KB, patch)
2011-10-03 08:48 PDT, Victor Porof [:vporof][:vp]
dcamp: review+
Details | Diff | Review
UI height preferences + review fixes (13.97 KB, patch)
2011-10-03 09:37 PDT, Victor Porof [:vporof][:vp]
dcamp: review+
Details | Diff | Review

Description Panos Astithas [:past] 2011-09-14 09:14:56 PDT
The script debugger UI will be often resized to fit the needs of a particular user or use case. On subsequent debugger invocations the UI should have the same size as the last time it was closed. There is some similar code in the HUDService that we could repurpose.
Comment 1 Victor Porof [:vporof][:vp] 2011-10-03 00:19:23 PDT
Created attachment 564128 [details] [diff] [review]
UI height preferences + tests
Comment 2 Panos Astithas [:past] 2011-10-03 07:24:22 PDT
You might want to fix this warning while you're here:

JavaScript strict warning: chrome://browser/content/debugger/debugger-view.js, line 318: function DVS_addScript does not always return a value
Comment 3 Victor Porof [:vporof][:vp] 2011-10-03 07:49:33 PDT
(In reply to Panos Astithas [:past] from comment #2)
> You might want to fix this warning while you're here:
> 
> JavaScript strict warning:
> chrome://browser/content/debugger/debugger-view.js, line 318: function
> DVS_addScript does not always return a value

Hmm, I wonder why jshint didn't warn me about that. Thanks, will fix.
Comment 4 Victor Porof [:vporof][:vp] 2011-10-03 08:48:38 PDT
Created attachment 564203 [details] [diff] [review]
UI height preferences + tests + minor changes in debugger-view
Comment 5 Dave Camp (:dcamp) 2011-10-03 09:15:55 PDT
Comment on attachment 564203 [details] [diff] [review]
UI height preferences + tests + minor changes in debugger-view

Review of attachment 564203 [details] [diff] [review]:
-----------------------------------------------------------------

The test should verify that a resize + close properly saves the pref.

r+ with a test fix and a $ectomy.

::: browser/devtools/debugger/content/debugger-prefs.js
@@ +186,5 @@
> +
> +  /**
> +   * The preferences branch for this tool.
> +   */
> +  $branch: "devtools.debugger."

This snuck in.
Comment 6 Victor Porof [:vporof][:vp] 2011-10-03 09:37:03 PDT
Created attachment 564220 [details] [diff] [review]
UI height preferences + review fixes

Note You need to log in before you can comment on or make changes to this bug.