Closed Bug 686684 Opened 12 years ago Closed 12 years ago

The debugger UI should remember its size across sessions

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: past, Assigned: vporof)

References

Details

Attachments

(2 files, 1 obsolete file)

UI height preferences + tests + minor changes in debugger-view
13.65 KB, patch
dcamp
: review+
Details | Diff | Splinter Review
UI height preferences + review fixes
13.97 KB, patch
dcamp
: review+
Details | Diff | Splinter Review 
The script debugger UI will be often resized to fit the needs of a particular user or use case. On subsequent debugger invocations the UI should have the same size as the last time it was closed. There is some similar code in the HUDService that we could repurpose.
Assignee: nobody → vporof
Attached patch UI height preferences + tests (obsolete) — — Splinter Review 

        Attachment #564128 -
        Flags: review?(dcamp)

    
    

    
  
You might want to fix this warning while you're here:

JavaScript strict warning: chrome://browser/content/debugger/debugger-view.js, line 318: function DVS_addScript does not always return a value

    
    

    
  
(In reply to Panos Astithas [:past] from comment #2)
> You might want to fix this warning while you're here:
> 
> JavaScript strict warning:
> chrome://browser/content/debugger/debugger-view.js, line 318: function
> DVS_addScript does not always return a value

Hmm, I wonder why jshint didn't warn me about that. Thanks, will fix.

    
    

    
  
Comment on attachment 564203 [details] [diff] [review]
UI height preferences + tests + minor changes in debugger-view

Review of attachment 564203 [details] [diff] [review]:
-----------------------------------------------------------------

The test should verify that a resize + close properly saves the pref.

r+ with a test fix and a $ectomy.

::: browser/devtools/debugger/content/debugger-prefs.js
@@ +186,5 @@
> +
> +  /**
> +   * The preferences branch for this tool.
> +   */
> +  $branch: "devtools.debugger."

This snuck in.

        Attachment #564203 -
        Flags: review?(dcamp) → review+

    
    

    
  


  

        Attachment #564128 -
        Attachment is obsolete: true

        Attachment #564128 -
        Flags: review?(dcamp)

    
  

        Attachment #564220 -
        Flags: review+

    
    

    
  
http://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/fa69b03a71d7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.