The default bug view has changed. See this FAQ.

The debugger UI should remember its size across sessions

RESOLVED FIXED

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: past, Assigned: vporof)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

The script debugger UI will be often resized to fit the needs of a particular user or use case. On subsequent debugger invocations the UI should have the same size as the last time it was closed. There is some similar code in the HUDService that we could repurpose.
Blocks: 676586
(Assignee)

Updated

6 years ago
Assignee: nobody → vporof
(Assignee)

Comment 1

6 years ago
Created attachment 564128 [details] [diff] [review]
UI height preferences + tests
Attachment #564128 - Flags: review?(dcamp)
You might want to fix this warning while you're here:

JavaScript strict warning: chrome://browser/content/debugger/debugger-view.js, line 318: function DVS_addScript does not always return a value
(Assignee)

Comment 3

6 years ago
(In reply to Panos Astithas [:past] from comment #2)
> You might want to fix this warning while you're here:
> 
> JavaScript strict warning:
> chrome://browser/content/debugger/debugger-view.js, line 318: function
> DVS_addScript does not always return a value

Hmm, I wonder why jshint didn't warn me about that. Thanks, will fix.
(Assignee)

Comment 4

6 years ago
Created attachment 564203 [details] [diff] [review]
UI height preferences + tests + minor changes in debugger-view
Attachment #564203 - Flags: review?(dcamp)

Comment 5

6 years ago
Comment on attachment 564203 [details] [diff] [review]
UI height preferences + tests + minor changes in debugger-view

Review of attachment 564203 [details] [diff] [review]:
-----------------------------------------------------------------

The test should verify that a resize + close properly saves the pref.

r+ with a test fix and a $ectomy.

::: browser/devtools/debugger/content/debugger-prefs.js
@@ +186,5 @@
> +
> +  /**
> +   * The preferences branch for this tool.
> +   */
> +  $branch: "devtools.debugger."

This snuck in.
Attachment #564203 - Flags: review?(dcamp) → review+
(Assignee)

Comment 6

6 years ago
Created attachment 564220 [details] [diff] [review]
UI height preferences + review fixes
Attachment #564128 - Attachment is obsolete: true
Attachment #564128 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #564220 - Flags: review+
(Assignee)

Comment 7

6 years ago
http://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/fa69b03a71d7
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.