Closed
Bug 686684
Opened 14 years ago
Closed 14 years ago
The debugger UI should remember its size across sessions
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: past, Assigned: vporof)
References
Details
Attachments
(2 files, 1 obsolete file)
13.65 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
13.97 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
The script debugger UI will be often resized to fit the needs of a particular user or use case. On subsequent debugger invocations the UI should have the same size as the last time it was closed. There is some similar code in the HUDService that we could repurpose.
Assignee | ||
Updated•14 years ago
|
Assignee: nobody → vporof
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #564128 -
Flags: review?(dcamp)
Reporter | ||
Comment 2•14 years ago
|
||
You might want to fix this warning while you're here:
JavaScript strict warning: chrome://browser/content/debugger/debugger-view.js, line 318: function DVS_addScript does not always return a value
Assignee | ||
Comment 3•14 years ago
|
||
(In reply to Panos Astithas [:past] from comment #2)
> You might want to fix this warning while you're here:
>
> JavaScript strict warning:
> chrome://browser/content/debugger/debugger-view.js, line 318: function
> DVS_addScript does not always return a value
Hmm, I wonder why jshint didn't warn me about that. Thanks, will fix.
Assignee | ||
Comment 4•14 years ago
|
||
Attachment #564203 -
Flags: review?(dcamp)
Comment 5•14 years ago
|
||
Comment on attachment 564203 [details] [diff] [review]
UI height preferences + tests + minor changes in debugger-view
Review of attachment 564203 [details] [diff] [review]:
-----------------------------------------------------------------
The test should verify that a resize + close properly saves the pref.
r+ with a test fix and a $ectomy.
::: browser/devtools/debugger/content/debugger-prefs.js
@@ +186,5 @@
> +
> + /**
> + * The preferences branch for this tool.
> + */
> + $branch: "devtools.debugger."
This snuck in.
Attachment #564203 -
Flags: review?(dcamp) → review+
Assignee | ||
Comment 6•14 years ago
|
||
Attachment #564128 -
Attachment is obsolete: true
Attachment #564128 -
Flags: review?(dcamp)
Updated•14 years ago
|
Attachment #564220 -
Flags: review+
Assignee | ||
Comment 7•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•