Don't extract libraries

VERIFIED FIXED in mozilla9

Status

()

Core
Widget: Android
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla9
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mobilestartupshrink])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
On a lot of devices, extracted libraries are a perf hit because of filesystem and/or flash suckage. On the fastest devices, however, we don't get much benefit from extracted libraries. All in all, it would be better for everyone if we just skipped that.

There are however a few things to care about:
- extracted libs are necessary for gdb to work properly (at least currently)
- we need to clean-up the extracted libraries from previous versions

For the former, we could either enable library extraction on the debug intent, but that means we probably need to delay library loading until onResume to have the intent (wouldn't be an actual measurable delay, though, more of a code concern). Or, we could add a pref at the java app level.

Updated

6 years ago
Depends on: 686728
(Assignee)

Comment 1

6 years ago
Created attachment 560415 [details] [diff] [review]
Don't extract libraries on Android unless we're starting with the DEBUG intent
Attachment #560415 - Flags: review?(doug.turner)

Comment 2

6 years ago
Comment on attachment 560415 [details] [diff] [review]
Don't extract libraries on Android unless we're starting with the DEBUG intent

Review of attachment 560415 [details] [diff] [review]:
-----------------------------------------------------------------

can we remove kFreeSpaceThreshold?
Attachment #560415 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 560461 [details] [diff] [review]
Don't extract libraries on Android unless we're starting with the DEBUG intent

sure, and kLibFreeSpaceBuffer as well.
(Assignee)

Updated

6 years ago
Attachment #560415 - Attachment is obsolete: true
(Assignee)

Comment 4

6 years ago
Comment on attachment 560461 [details] [diff] [review]
Don't extract libraries on Android unless we're starting with the DEBUG intent

carrying r+ over
Attachment #560461 - Flags: review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/49c16f43ff26
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
(Assignee)

Comment 6

6 years ago
Created attachment 560530 [details] [diff] [review]
Remove library extraction splash screen
Attachment #560530 - Flags: review?(mark.finkle)
Attachment #560530 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/f4d78560721a
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110917 Firefox/9.0a1 Fennec/9.0a1
Status: RESOLVED → VERIFIED
(Assignee)

Updated

6 years ago
Blocks: 692381
You need to log in before you can comment on or make changes to this bug.