Closed Bug 686694 Opened 10 years ago Closed 10 years ago

Don't extract libraries

Categories

(Core :: Widget: Android, defect)

ARM
Android
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla9

People

(Reporter: glandium, Assigned: glandium)

References

Details

(Whiteboard: [mobilestartupshrink])

Attachments

(2 files, 1 obsolete file)

On a lot of devices, extracted libraries are a perf hit because of filesystem and/or flash suckage. On the fastest devices, however, we don't get much benefit from extracted libraries. All in all, it would be better for everyone if we just skipped that.

There are however a few things to care about:
- extracted libs are necessary for gdb to work properly (at least currently)
- we need to clean-up the extracted libraries from previous versions

For the former, we could either enable library extraction on the debug intent, but that means we probably need to delay library loading until onResume to have the intent (wouldn't be an actual measurable delay, though, more of a code concern). Or, we could add a pref at the java app level.
Depends on: 686728
Comment on attachment 560415 [details] [diff] [review]
Don't extract libraries on Android unless we're starting with the DEBUG intent

Review of attachment 560415 [details] [diff] [review]:
-----------------------------------------------------------------

can we remove kFreeSpaceThreshold?
Attachment #560415 - Flags: review?(doug.turner) → review+
sure, and kLibFreeSpaceBuffer as well.
Attachment #560415 - Attachment is obsolete: true
Comment on attachment 560461 [details] [diff] [review]
Don't extract libraries on Android unless we're starting with the DEBUG intent

carrying r+ over
Attachment #560461 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/49c16f43ff26
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
Attachment #560530 - Flags: review?(mark.finkle)
Attachment #560530 - Flags: review?(mark.finkle) → review+
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110917 Firefox/9.0a1 Fennec/9.0a1
Status: RESOLVED → VERIFIED
Blocks: 692381
You need to log in before you can comment on or make changes to this bug.