686694 - Don't extract libraries

Status: VERIFIED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Mike Hommey [:glandium]]

On a lot of devices, extracted libraries are a perf hit because of filesystem and/or flash suckage. On the fastest devices, however, we don't get much benefit from extracted libraries. All in all, it would be better for everyone if we just skipped that.

There are however a few things to care about:
- extracted libs are necessary for gdb to work properly (at least currently)
- we need to clean-up the extracted libraries from previous versions

For the former, we could either enable library extraction on the debug intent, but that means we probably need to delay library loading until onResume to have the intent (wouldn't be an actual measurable delay, though, more of a code concern). Or, we could add a pref at the java app level.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Don't extract libraries on Android unless we're starting with the DEBUG intent

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 560415 [details] [diff] [review]
Don't extract libraries on Android unless we're starting with the DEBUG intent

Review of attachment 560415 [details] [diff] [review]:
-----------------------------------------------------------------

can we remove kFreeSpaceThreshold?

Comment 3

[Mike Hommey [:glandium]]

Attachment: Don't extract libraries on Android unless we're starting with the DEBUG intent

sure, and kLibFreeSpaceBuffer as well.

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 560461 [details] [diff] [review]
Don't extract libraries on Android unless we're starting with the DEBUG intent

carrying r+ over

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/49c16f43ff26

Comment 6

[Mike Hommey [:glandium]]

Attachment: Remove library extraction splash screen

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/f4d78560721a

Comment 8

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20110917 Firefox/9.0a1 Fennec/9.0a1