687026 - [10.7] Add support look up gesture in Mac OS X 10.7 Lion

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Sebastian Krysmanski]

Attachment: Screen Shot 2011-09-16 at 09.33.58.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:6.0.2) Gecko/20100101 Firefox/6.0.2
Build ID: 20110902133214

Steps to reproduce:

I double tapped with three fingers on a word in a website.


Actual results:

Nothing happend.


Expected results:

According to the "System Preferences" (under "Trackpad" -> "Point & Click" -> "Look up") a double tap should lookup the selected word using the Dictionary. Works, for example, in Safari (see screenshot).

Comment 1

[Jo Hermans]

Probably dependent on bug 301451

Comment 3

[nortexoid]

Still not assigned to anyone? The feature is available in both Safari and Chrome for OS X, so it would be nice to see it in Firefox too (but I suppose that much is obvious).

Comment 5

[José Jeria]

Mountain Lion changed the gesture. You tap a word with three fingers now.

Comment 6

[Žilvinas]

Same problem with Mountain Lion for me. Not gestures so far..

Comment 7

[jothiram.s]

As mentioned above, both Safari and Chrome support it. It would be great if Firefox also supports it. 

Also the pinch-in, pinch-out zoom feature is not supported by default (one can enable by tweaking the about:config), while it is by default supported both in Safari and Chrome.

Comment 8

[Chandan Goopta]

I want to take this forward and start working to fix it. This is my first time working on bugzilla so anybody would mind to tell me how will this assigned to me?

Cheers

Comment 9

[Florian Bender]

Assignment is not necessary for starting to work on this bug. 

Only a user with the necessary privileges (mostly people from Mozilla) can change the assignee. Pinging.

Comment 10

[Florian Bender]

Thanks Sonny!

Comment 11

[Chandan Goopta]

Thanks Sonny and Florian :) .

Comment 12

[Markus Stange [:mstange]]

Chandan, I suggest you start by trying out the patches from bug 308471 and bug 301451 and see if that's enough to support this. You'll also have to find a solution for bug 569331 so that this does not only work for focused elements.
You can ping me on IRC #macdev if you have questions.

Comment 13

[Letian Grabo]

Hello,
did you had any progress fixing this Chandan?
i really hope you did

Comment 14

[frankfang1990]

Any progress?

Comment 15

[CaptSaltyJack]

It works in text boxes like the one I'm typing in, but it always looks up the definition for the very first word. So if I triple-finger-tap on the word "typing", it will look up "It" instead. So it semi-works but is very broken.

Comment 16

[Žilvinas]

(In reply to frankfang1990 from comment #14)
> Any progress?

Sadly, but it doesn't work.

Comment 17

[u500147]

Getting this feature done gives Firefox one of Safari's biggest features.

Comment 18

[bulutmfit]

Still not working as of Firefox 28.0.

Comment 19

[firefoxbugreport]

Three-finger tap for dictionary doesn't work on OS X Mavericks 10.9.2, with Firefox 29.0.1.

Comment 20

[Alex]

Any progress on this guys? This has been open for a very long time indeed!

Comment 21

[bassu]

Chromium already has it. Yay :-D
(Sarcasm)

Comment 22

[alswl]

Three-finger tap for dictionary doesn't work on OS X Mavericks 10.9.4, with Firefox 32.0.2.

Comment 24

[Steven Michaud [:smichaud] (Retired)]

Bug 1145224 is about the lookup gesture not working in the Preferences pane (or presumably anywhere you can't select text).

Comment 25

[Xidorn Quan [:xidorn] UTC+10]

Wasn't this bug already fixed by bug 308471? It seems I can use the gesture in web page wherever text can be selected. I think making lookup gesture working on non-selectable text is a topic unrelated to this bug.

Comment 26

[Elias Zamaria]

Why was this changed to WORKSFORME? I am running Firefox 37 on Yosemite. If I tap with 3 fingers on a word on a web page, nothing happens. But if I click somewhere on the page and then triple-tap, the lookup thing shows up. This is different from most other Mac apps (including Chrome and Safari) and something I think a lot of users will not discover and will instead think it is broken.

Comment 27

[Steven Michaud [:smichaud] (Retired)]

> Why was this changed to WORKSFORME?

It wasn't changed by me :-)

Comment 28

[Xidorn Quan [:xidorn] UTC+10]

Hmm, I think this bug should be marked as resolved, because it works since Firefox 34. But given it depends on the meta bug we track the implementation of dictionary lookup, which still has several depending bugs open, probably we could reopen it.

Comment 29

[Elias Zamaria]

I looked through some of the dictionary-related bugs. I don't know if the behavior I described in my above comment is covered by bug 569331 or if it is a separate issue.

Comment 30

[Xidorn Quan [:xidorn] UTC+10]

I think that is an issue covered by bug 569331.

Comment 31

[jagger27.com]

Bug has resurfaced on OS X 10.11 (El Capitan) on Firefox 40.0.3.

Comment 32

[Adrian Nabarro]

(In reply to jagger27.com from comment #31)
> Bug has resurfaced on OS X 10.11 (El Capitan) on Firefox 40.0.3.

Confirmed in 42.0a2 (2015-09-14) too

Comment 33

[Žilvinas]

(In reply to Adrian Nabarro from comment #32)
> (In reply to jagger27.com from comment #31)
> > Bug has resurfaced on OS X 10.11 (El Capitan) on Firefox 40.0.3.
> 
> Confirmed in 42.0a2 (2015-09-14) too

Confirmed on FF 42.0a2 (2015-09-21) too.

Comment 34

[Handres Povidaiko]

(In reply to Žilvinas from comment #33)
> (In reply to Adrian Nabarro from comment #32)
> > (In reply to jagger27.com from comment #31)
> > > Bug has resurfaced on OS X 10.11 (El Capitan) on Firefox 40.0.3.
> > 
> > Confirmed in 42.0a2 (2015-09-14) too
> 
> Confirmed on FF 42.0a2 (2015-09-21) too.

Confirmed on FF 41.0.1 (2015-10-11) too.

Comment 35

[Markus Stange [:mstange]]

Bug 1212527 has been filed about El Capitan support.

Comment 36

[shoully]

(In reply to Handres Povidaiko from comment #34)
> (In reply to Žilvinas from comment #33)
> > (In reply to Adrian Nabarro from comment #32)
> > > (In reply to jagger27.com from comment #31)
> > > > Bug has resurfaced on OS X 10.11 (El Capitan) on Firefox 40.0.3.
> > > 
> > > Confirmed in 42.0a2 (2015-09-14) too
> > 
> > Confirmed on FF 42.0a2 (2015-09-21) too.
> 
> Confirmed on FF 41.0.1 (2015-10-11) too.

Confirmed on FF 43.0.4 (2016-01-25) too.

Comment 37

[steve]

Also title should be adjusted, since from what I understand OS X 10.7 - 10.11 is affected. At least in my tests w 10.11.3 this issue was reproducible. So all OS X versions from the last 5 years or more are affected.

Comment 38

[Xidorn Quan [:xidorn] UTC+10]

(In reply to steve-_- from comment #37)
> Also title should be adjusted, since from what I understand OS X 10.7 -
> 10.11 is affected. At least in my tests w 10.11.3 this issue was
> reproducible. So all OS X versions from the last 5 years or more are
> affected.

It works from 10.7 to 10.10. Since 10.11, Apple removed the old API which the current implementation depends on, which is bug 1212527.

Comment 39

[shoully]

The bug still faced on OS X 10.11.2 (El Capitan)

Confirmed on FF 44.0 (2016-01-27).

Comment 40

[Xidorn Quan [:xidorn] UTC+10]

I'm going to close this bug, since this gesture actually works on 10.7 ~ 10.10. This being broken again since 10.11 is bug 1212527.

Comment 41

[steve]

Good idea. This was rather confusing and obviously incorrect. Thanks for cleaning the bug tracker. Now let's hope Mozilla can address #1212527.

Comment 42

[shoully]

This bug fixed in macOS Sierra 10.12.1 Beta 5.

I just upgrade from Sierra beta 4 to beta 5 and the three look up gesture works again, after it stopped back in El Captain.

Comment 43

[RB]

This bug is still open in macOS 10.13.6 with Firefox 63.0

Comment 44

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to RB from comment #43)
> This bug is still open in macOS 10.13.6 with Firefox 63.0

Please file a new bug, we cannot track changes on a closed bug.