The default bug view has changed. See this FAQ.

Clicking on a stack frame in the debugger should put the caret in the proper source line

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Firefox 13
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 4 obsolete attachments)

When a user clicks on a stack frame, the source editor pane should scroll the corresponding line into view (preferably at the top of the pane) and put the caret there. Highlighting the line would be nice, too.
Blocks: 676586
Depends on: 687160
Component: Developer Tools → Developer Tools: Debugger
QA Contact: developer.tools → developer.tools.debugger
Assignee: nobody → past
Status: NEW → ASSIGNED
Priority: -- → P2
Depends on: 706506
Created attachment 592126 [details] [diff] [review]
WIP

Clicking on a stack frame now works as expected, but when entering the paused state the right script and line are not automatically selected. This cannot be fixed until bug 706506 is taken care of.
Created attachment 592834 [details] [diff] [review]
WIP 2

This works now (on top of bug 706506), but the test still has a couple of failures that I need to get to the bottom of.
Attachment #592126 - Attachment is obsolete: true
Created attachment 593134 [details] [diff] [review]
Working patch

Fixed the test as well as a few others that this patch broke, and added an extra fix for a flicker during onScripts.
Attachment #592834 - Attachment is obsolete: true
Attachment #593134 - Flags: review?(mihai.sucan)
Comment on attachment 593134 [details] [diff] [review]
Working patch

Review of attachment 593134 [details] [diff] [review]:
-----------------------------------------------------------------

Patch looks good!

::: browser/devtools/debugger/test/browser_dbg_select-line.js
@@ +69,5 @@
> +        });
> +      });
> +
> +      // Click the oldest stack frame.
> +      EventUtils.sendMouseEvent({ type: "click" },

Can you use synthesizeMouse() here?
Attachment #593134 - Flags: review?(mihai.sucan) → review+
Created attachment 593427 [details] [diff] [review]
Working patch v2

(In reply to Mihai Sucan [:msucan] from comment #4)
> Comment on attachment 593134 [details] [diff] [review]
> Working patch
> 
> Review of attachment 593134 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Patch looks good!
> 
> ::: browser/devtools/debugger/test/browser_dbg_select-line.js
> @@ +69,5 @@
> > +        });
> > +      });
> > +
> > +      // Click the oldest stack frame.
> > +      EventUtils.sendMouseEvent({ type: "click" },
> 
> Can you use synthesizeMouse() here?

Absolutely, fixed.

(carrying over the r+)
Attachment #593134 - Attachment is obsolete: true
Attachment #593427 - Flags: review+
Created attachment 596060 [details] [diff] [review]
[in-fx-team] Working patch v3

Test fix required after the latest merge and a small hunk from the patch in bug 711164, since I reordered them. This hunk has extensive tests in that patch, but I wanted to get this in and not wait for stepping support to be finished.
Attachment #593427 - Attachment is obsolete: true
Attachment #596060 - Flags: review?(dcamp)
Created attachment 596061 [details] [diff] [review]
Diff between v2 and v3

Changes since your last review.
Comment on attachment 596060 [details] [diff] [review]
[in-fx-team] Working patch v3

Sorry, I got confused. Mihai has been reviewing this.
Attachment #596060 - Flags: review?(dcamp) → review?(mihai.sucan)
Comment on attachment 596060 [details] [diff] [review]
[in-fx-team] Working patch v3

Looks good!
Attachment #596060 - Flags: review?(mihai.sucan) → review+
Whiteboard: [land-in-fx-team]
Attachment #596060 - Attachment description: Working patch v3 → [in-fx-team] Working patch v3
https://hg.mozilla.org/integration/fx-team/rev/c17bad2abafe
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/c17bad2abafe
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
Depends on: 726609
You need to log in before you can comment on or make changes to this bug.