Last Comment Bug 687422 - Remove isElementContentWhitespace
: Remove isElementContentWhitespace
Status: RESOLVED FIXED
: addon-compat, dev-doc-complete
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: :Ms2ger (⌚ UTC+1/+2)
:
Mentors:
Depends on: 688190
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-19 02:41 PDT by Anne (:annevk)
Modified: 2011-11-22 04:36 PST (History)
6 users (show)
Ms2ger: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1 (2.10 KB, patch)
2011-09-19 08:57 PDT, :Ms2ger (⌚ UTC+1/+2)
jonas: review+
Details | Diff | Splinter Review

Description Anne (:annevk) 2011-09-19 02:41:48 PDT
Text.isElementContentWhitespace is no longer part of the DOM standard.
Comment 1 Anne (:annevk) 2011-09-19 07:33:42 PDT
WebKit does not support this attribute. I filed a bug on Opera for removing it there (along with replaceWholeText()).
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2011-09-19 08:57:04 PDT
Created attachment 560927 [details] [diff] [review]
Patch v1
Comment 3 :Ms2ger (⌚ UTC+1/+2) 2011-10-09 05:57:28 PDT
Jonas?
Comment 4 Jonas Sicking (:sicking) PTO Until July 5th 2011-10-10 01:55:14 PDT
Comment on attachment 560927 [details] [diff] [review]
Patch v1

Hrm.. this actually seemed like a useful function. It always feels silly to me when all browsers have to have state or functionality internally that isn't exposed to the webpage.

So I'd be in favor of keeping this in spec/implementations. But if people prefer to remove it then I won't stand in the way.
Comment 5 Anne (:annevk) 2011-10-12 02:11:16 PDT
The current name does not make any sense. I would be open to renaming it. E.g. Text.isWhiteSpace. I used an uppercase S for consistency with white-space in CSS.
Comment 6 Jonas Sicking (:sicking) PTO Until July 5th 2011-10-12 16:30:33 PDT
I'd be fine with that.
Comment 7 Anne (:annevk) 2011-10-13 01:38:05 PDT
I filed http://www.w3.org/Bugs/Public/show_bug.cgi?id=14443 on adding Text.isWhiteSpace to DOM4, but Simon rightly asks what the use case is and I have no idea.
Comment 8 :Ms2ger (⌚ UTC+1/+2) 2011-10-15 03:00:24 PDT
https://hg.mozilla.org/mozilla-central/rev/292803c8c406
Comment 10 Jean-Yves Perrier [:teoli] 2011-11-19 10:32:57 PST
Oops, wrong bug (sorry for the spam).

Note You need to log in before you can comment on or make changes to this bug.