68789 - New Folder dialog is too small

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Mirek Hankus]

1. RightClick on one of subscribed folders, select  New Subfolder. 
2. New dialog appears titled New Folder in which buttons OK and Cancel 
 are not visible.

I'll attach screenshot

Build id: 2001021320
I have fonts set to Large Fontst on my Windows (if it matters).

Comment 1

[Mirek Hankus]

Attachment: Screenshot of NewFolder dialog

Comment 2

[Håkan Waara]

Worksforme using a 02/12 build. This may be a theme problem, or something that
has to do with your big font.

Reporter, is this also happening in Classic for you?  Cc'ing hewitt.

Comment 3

[(not reading, please use [e-mail] instead)]

new folder -> naving.

Comment 4

[laurel]

I think there is already a bug about this...

Comment 5

[Navin Gupta]

To get rid of window.sizeToContent() , we had to use fixed sizes as 
shown in the patch submitted by [e-mail]. Here is what the problem will 
be with fixed size window, when font size changes.

From the last patch in bug #52564. This bug cannot be fixed until 
window.sizeToContent works on all platforms

RCS file: /cvsroot/mozilla/mailnews/base/resources/content/newFolderDialog.xul,v
retrieving revision 1.1
diff -u -r1.1 newFolderDialog.xul

We cannot do much until window.sizeToContent() is fixed for all platforms
--- newFolderDialog.xul 2000/12/16 00:42:38     1.1
+++ newFolderDialog.xul 2000/12/21 00:26:43
@@ -34,6 +34,7 @@
         title="&newFolderDialog.title;"
         align="vertical"
         class="dialog"
+        width="200" height="180"
         onload="onLoad();">
 
   <script type="text/javascript" src="chrome://global/content/strres.js"/>
@@ -54,7 +55,7 @@
     <text value="&description.label;" class="label" 
accesskey="&description.accesskey;" for="msgNewFolderPicker"/>
 
     <box align="horizontal">
-      <menu id="msgNewFolderPicker" oncommand="doEnabling(); 
window.sizeToContent();"/>
+      <menu id="msgNewFolderPicker" oncommand="doEnabling();" crop="right" 
flex="1"/>
       <spring flex="1"/>
     </box>

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 72662 has been marked as a duplicate of this bug. ***

Comment 7

[Boris Zbarsky [:bzbarsky]]

adding window.sizeToContent() bug as a blocker.

Can we do heights in units other than px? If we can size in em, that would be
very nice....

os->all -- happens to anyone with a high-res screen.

Comment 8

[Alexey Chernyak]

Navi, The dialog looks even worse with Classic theme (see screenshot in bug 72662 ).
Can't see what the buttons are, and wether they are buttons at all or something
else.

can you just make it a bit bigger in newFolderDialog.xul?

- width="200" height="180"
+ width="260" height="210"

those sizes should make buttons visible on high resolution screens.

Comment 9

[Alexey Chernyak]

Attachment: proposed patch

Comment 10

[Alexey Chernyak]

the above fix does it for me
dialog appears just right on Win2K in high res

I'm not sure how it will affect IMAP stuff in bug 52564

Comment 11

[Navin Gupta]

No, this is not the correct fix. I will investigate if sizeToContent() is working 
now ?

Comment 12

[Alexey Chernyak]

I understand you would like to use sizeToContent() for this dialog and probably
for many other dialogs as well.
I didn't find any reference to sizeToContent() in newFolderDialog.js, yet when
you don't explicitly specify window size in newFolderDialog.xul the window sizes
itself properly under Win2K.
If sizeToContent() is called for it frome some other place I can understand your
concern about it crashing Linux machines.
Or maybe other OSes don't handle this the same way Windows does and this fix
doesn't work for them.

In either way, the issue of sizing of this dialog has been addressed in bug
52564, and as I understand a temp fix has been placed by setting a fixed window
size. That size however is too small for high res screens, and buttons are not
visible, especially under Classic theme.

If the above fix doesn't work for anything else apart from Windows, it would be
good to adjust the fixed size to make everyone happy until sizeToContent() is fixed.

attaching new small fix.

Comment 13

[Alexey Chernyak]

Attachment: patch

Comment 14

[Håkan Waara]

related to bug 69702?

Comment 15

[Alexey Chernyak]

*** Bug 81644 has been marked as a duplicate of this bug. ***

Comment 16

[Koike Kazuhiko]

Removing <width="200" height="180"> seems to fix this bug. Isn't this correct?

Comment 17

[Navin Gupta]

I am working on UW:IMAP new folder dialog bug 52564, will fix this also. 

Comment 18

[JongAm Park]

*** Bug 84987 has been marked as a duplicate of this bug. ***

Comment 19

[Håkan Waara]

*** Bug 87789 has been marked as a duplicate of this bug. ***

Comment 20

[Håkan Waara]

Navin, if that other bug will fix this - then please duplicate this and adjust
the summary on the new bug.

Comment 21

[Navin Gupta]

this should be fixed because of the partial fix landed for #52564

Comment 22

[Keyser Sose]

*** Bug 84538 has been marked as a duplicate of this bug. ***

Comment 23

[Sheela Ravindran]

verified,
win98, mac, linux-trunk build 2001080208