688111 - Toolbar-Customizing errors & *hang* related to menu-bar (reproducible in last nightly).

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Javier "Darth"]

Build identifier: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:9.0a1) Gecko/20110920 Firefox/9.0a1


Using Customize Toolbars feature, I can get Firefox in a 'hanged' state, with disabled Main Menu (in menubar) and disabled Customize menu-entry in toolbars-context-menu.
I can reproduce this in last (updated) nightly portable (from portableapps.com) in -safe mode- (happened also in my regular Firefox 6)

Reproducible: Always

Steps to reproduce:

1- Run nightly and do: help > Restart with addons disabled. On restart click in 'Continue in safe mode'

2- Press ctrl+shift+j to open Error Console

3- Switch to nightly window again. With menu-bar not-visible (unchecked, default) right click on tabbar bkg, in the popup-context-menu click CUSTOMIZE.

4- With Customize toolbar dialog opened, right click again in MENU-BAR bkg (currently visible), and in popup-context-menu click 'MENU BAR' to check (enable) it!.

5- Switch to error console to see this error:
    Error: this.toolbar._setInactiveAsync is not a function
    Source File: chrome://global/content/bindings/toolbar.xml
    Line: 428
	(This is inside   <binding id="toolbar-menubar-autohide" ...>)
	
6- In nightly, click 'DONE' to dismiss Customize-toolbar dialog.    
   Again in error console see this error:
 *	Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIObserverService.removeObserver]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  
	location: "JS frame :: chrome://browser/content/search/search.xml ::  :: line 91"  data: no]
	
7- Again in nightly, right click on tabbar bkg, in the popup-context-menu click CUSTOMIZE.
   In error console see these errors:
 *	Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIControllers.removeController]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  
	location: "JS frame :: chrome://browser/content/places/browserPlacesViews.js :: PVB_uninit :: line 672"  data: no]
 *	Error: this.toolbar._setInactiveAsync is not a function
	Source File: chrome://global/content/bindings/toolbar.xml
	Line: 428	
	
8- In nightly you can see that It now remains in a 'hanged-like' customizing state, the Customize option entry & Main Menu remains disabled!


In my somewhat limited knowledge of the code (I'm a addon developer btw) I'd suggest at least some clever try-catch to avoid leaving the customizing-state like 'hanged'. I think this because I got at least some *other* browser.js error when closing Customize-dialog before in my Fx6, that leaved Fx in this same customizing-'hanged' state. (I'll try to reproduce that again).

Regards!

Comment 1

[Javier "Darth"]

Another visible glitch I can get (in nightly & Fx6) is that some things like spaces and separators can get *duplicated* in menu-bar when done customizing:

After step 3 (from above):
3.1- Drag a flexible-space and a separator to menu-bar (at right of main-menu) 
3.2- In nightly, click 'DONE' to dismiss Customize-toolbar dialog.
3.3- Activate CUSTOMIZE again. (like step 3)

4- Perform this step 4 (check 'Menu Bar').  You can see that the space & separator got duplicated.

Comment 2

[Alice0775 White]

Reproduced on Firefoc7b5 to Nightly9.0a1

Steps to reproduce:
1. Start Firefox with clean profile
2. Right click toolbar to Customize Toolbar...
3. Right click toolbar and Enable Menu Bar
4. Done Customize Toolbar
5. Right click toolbar to Customize Toolbar again

Actual Results:
  Nothing happen.

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIControllers.removeController]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/places/browserPlacesViews.js :: PVB_uninit :: line 672"  data: no]

    if (this._controller) {
      this._controller.terminate();
>     this._viewElt.controllers.removeController(this._controller);
      this._controller = null;
    }


Expected Results:
  Customize Toolbar dialog should pop up.

Regression window(cached m-c hourly),
Works:
http://hg.mozilla.org/mozilla-central/rev/5795ed49996d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110609 Firefox/7.0a1 ID:20110609002509
Fails:
http://hg.mozilla.org/mozilla-central/rev/a03bb9c49e42
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110609 Firefox/7.0a1 ID:20110609031754
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5795ed49996d&tochange=a03bb9c49e42
Triggered by:
1789ade94d5	ithinc — Bug 606884 - Remove the Places controller on view uninit. r=mak

Comment 3

[Alice0775 White]

(In reply to Javier "Darth Madara" from comment #1)
> Another visible glitch I can get (in nightly & Fx6) is that some things like
> spaces and separators can get *duplicated* in menu-bar when done customizing:
> 
> After step 3 (from above):
> 3.1- Drag a flexible-space and a separator to menu-bar (at right of
> main-menu) 
> 3.2- In nightly, click 'DONE' to dismiss Customize-toolbar dialog.
> 3.3- Activate CUSTOMIZE again. (like step 3)
> 
> 4- Perform this step 4 (check 'Menu Bar').  You can see that the space &
> separator got duplicated.

This is another bug,
I filed Bug 688933

Comment 4

[ithinc]

(In reply to Alice0775 White from comment #2)
> Regression window(cached m-c hourly),
> Works:
> http://hg.mozilla.org/mozilla-central/rev/5795ed49996d
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110609 Firefox/7.0a1
> ID:20110609002509
> Fails:
> http://hg.mozilla.org/mozilla-central/rev/a03bb9c49e42
> Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110609 Firefox/7.0a1
> ID:20110609031754
> Pushlog:
> http://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=5795ed49996d&tochange=a03bb9c49e42
> Triggered by:
> 1789ade94d5	ithinc — Bug 606884 - Remove the Places controller on view
> uninit. r=mak

Not really. It depends on the "this.toolbar._setInactiveAsync is not a function" error, which makes the Places Toolbar in an abnormal state.

Comment 5

[ithinc]

Steps to reproduce in Firefox 6.0.2:
1. Start Firefox with clean profile
2. Right click toolbar to Customize Toolbar...
3. Right click toolbar and Enable Menu Bar
4. Done Customize Toolbar
5. Right click a bookmark in the toolbar, and select "Open"

Actual Results:
  Nothing happen.

Comment 6

[Alice0775 White]

(In reply to ithinc from comment #5)
> Steps to reproduce in Firefox 6.0.2:
> 1. Start Firefox with clean profile
> 2. Right click toolbar to Customize Toolbar...
> 3. Right click toolbar and Enable Menu Bar
> 4. Done Customize Toolbar
> 5. Right click a bookmark in the toolbar, and select "Open"
> 
> Actual Results:
>   Nothing happen.

This is Bug 625778.

Comment 7

[Alice0775 White]

I suggest that the meuitem of toggling toolbar in "toolbar-context-menu" should be disabled while customizing toolbar.
So, this Bug 688933 and Bug 688111 will not happen.

Comment 8

[Mark Banner (:standard8)]

I've just tested this in 58.0.1 and it is all working fine with no errors being logged.

Customize has changed a bit in the last few years, so I suspect it got fixed along the way.