Closed
Bug 688547
Opened 13 years ago
Closed 13 years ago
Use Element* for nsIDocument::{SetSubDocumentFor,FindContentForSubDocument}
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
Attachments
(1 file)
10.37 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #561807 -
Flags: review?(peterv)
Flags: in-testsuite-
Comment 1•13 years ago
|
||
I have to ask... why do we have this at all? Can we just have nsIDocument hold a ref to its relevant frame element, if any?
Comment 2•13 years ago
|
||
peterv: ping?
Comment 3•13 years ago
|
||
Comment on attachment 561807 [details] [diff] [review] Patch v1 Review of attachment 561807 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/base/public/nsIDocument.h @@ +516,5 @@ > > /** > * Get the sub document for aContent > */ > + virtual nsIDocument *GetSubDocumentFor(nsIContent* aContent) const = 0; I dislike formatting-only changes like this. (And shouldn't you have changed the |nsIDocument *|?) @@ +521,5 @@ > > /** > * Find the content node for which aDocument is a sub document. > */ > + virtual Element* FindContentForSubDocument(nsIDocument *aDocument) const = 0; And I especially don't understand why you'd not do the formatting change here. ::: content/base/src/nsDocument.cpp @@ +3272,5 @@ > const_cast<SubDocMapEntry *> > (static_cast<const SubDocMapEntry *>(entry)); > > + e->mKey = const_cast<Element*> > + (static_cast<const Element*>(key)); Rewrap.
Attachment #561807 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/df4b49fffc78
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•