688547 - Use Element* for nsIDocument::{SetSubDocumentFor,FindContentForSubDocument}

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Boris Zbarsky [:bzbarsky]]

I have to ask... why do we have this at all?  Can we just have nsIDocument hold a ref to its relevant frame element, if any?

Comment 2

[(no longer active)]

peterv: ping?

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 561807 [details] [diff] [review]
Patch v1

Review of attachment 561807 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/public/nsIDocument.h
@@ +516,5 @@
>  
>    /**
>     * Get the sub document for aContent
>     */
> +  virtual nsIDocument *GetSubDocumentFor(nsIContent* aContent) const = 0;

I dislike formatting-only changes like this. (And shouldn't you have changed the |nsIDocument *|?)

@@ +521,5 @@
>  
>    /**
>     * Find the content node for which aDocument is a sub document.
>     */
> +  virtual Element* FindContentForSubDocument(nsIDocument *aDocument) const = 0;

And I especially don't understand why you'd not do the formatting change here.

::: content/base/src/nsDocument.cpp
@@ +3272,5 @@
>      const_cast<SubDocMapEntry *>
>                (static_cast<const SubDocMapEntry *>(entry));
>  
> +  e->mKey = const_cast<Element*>
> +                      (static_cast<const Element*>(key));

Rewrap.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/df4b49fffc78