Closed
Bug 688693
Opened 14 years ago
Closed 14 years ago
[TABLETUI] Tweak selected tab in portrait mode
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 9
People
(Reporter: wesj, Assigned: wesj)
References
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
For some reason the selected tab's favicon is slightly shifted to the right. All the favicons should line up.
|
||
Comment 1•14 years ago
|
||
While you're in that code, I noticed that pages with no favicon (about:firefox) don't show the default favicon
|
Assignee | |
Comment 2•14 years ago
|
||
So I needed to use !important in this case to enforce a min-width on the checkmark (even when its not showing).
Also added some checks to make sure url is not "about:blank" and to use the favicon service if the tab doesn't have a favicon given (which will send us the default one if it doesn't know of one either).
Assignee: nobody → wjohnston
Attachment #562077 -
Flags: review?(mark.finkle)
|
|
||
Updated•14 years ago
|
Attachment #562077 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 9
|
||
Comment 5•14 years ago
|
||
Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•