688800 - [tabletui] UI jumps around when tapping or scrolling in the tab sidebar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Steps to reproduce:
1. Open Fennec in landscape tablet mode with at least two tabs.
2. Tap in the sidebar to change tabs.

Expected results: Fennec switches tabs but nothing else changes.

Actual results: While your finger is down, the toolbar and browser content changes its layout.

This is because the customDragger code from bug 686417 is too grabby.  This patch makes it wait until you actually drag horizontally before grabbing the sidebar and changing the viewable area.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: part 2: hide curvy tab button at the start of the drag

Another kind of jumpiness: It looks weird to have the curvy tabs button still in the toolbar while dragging to show the sidebar, only to disappear when the drag finishes.

This patch causes the curvy button to disappear at the start of the drag, instead of the end, so that it's never visible at the same time as the sidebar.  They are like Bruce Wayne and Batman.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 562106 [details] [diff] [review]
part 2: hide curvy tab button at the start of the drag

Alfred approves

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b1f9800647c7
https://hg.mozilla.org/integration/mozilla-inbound/rev/27ea88e0c870

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b1f9800647c7
https://hg.mozilla.org/mozilla-central/rev/27ea88e0c870

Comment 5

[Cristian Nicolae (:xti)]

Verified fixed on:
Mozilla/5.0 (Android;Linux armv7l;rv:9.0a1)Gecko/20110926
Firefox/9.0a1 Fennec/9.0a1
Device: Acer ICONIA A500
OS: Android 3.1