Closed Bug 688991 Opened 8 years ago Closed 8 years ago

Plaintext part not sent for multipart alternatve send option

Categories

(Thunderbird :: Message Compose Window, defect, major)

x86
All
defect
Not set
major

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 9.0

People

(Reporter: JoeS1, Assigned: Bienvenu)

Details

(Keywords: regression)

Attachments

(1 file)

Steps:
Compose or reply to a message in html mode
Select Options>>Format>>Plain& Rich text to avoid any internal AB decisions.
Send or save the message locally and observe the result

Results:
Two copies of the html message are sent even though multipart/alternative is indicated in the header.

This happens in: 
Mozilla/5.0 (Windows NT 5.0; rv:9.0a1) Gecko/20110923 Thunderbird/9.0a1 ID:20110923030159
Not seen in the 20110920 build.

I strongly suspect bug 679476 as the problem
Summary: Plaintext part not sent for multipart alternatve sen option → Plaintext part not sent for multipart alternatve send option
taking...
Assignee: nobody → dbienvenu
Attached patch proposed fixSplinter Review
This is the part of the patch for bug 688991 where I messed this up:

-  if (NS_SUCCEEDED(status) && m_type && PL_strcasecmp(m_type, TEXT_PLAIN) )
+  if (NS_SUCCEEDED(status) && m_type.LowerCaseEqualsLiteral(TEXT_PLAIN) &&
+      m_desiredType.LowerCaseEqualsLiteral(TEXT_PLAIN))
   {
-    if (m_desired_type && !PL_strcasecmp(m_desired_type, TEXT_PLAIN) )
Attachment #562453 - Flags: review?(neil)
Attachment #562453 - Flags: review?(neil) → review+
fixed on trunk http://hg.mozilla.org/comm-central/rev/feb47379243c
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 9.0
Verified with Mozilla/5.0 (Windows NT 5.1; rv:10.0a1) Gecko/20111001 Thunderbird/10.0a1
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.