688991 - Plaintext part not sent for multipart alternatve send option

Status: VERIFIED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Joe Sabash [:JoeS1]]

Steps:
Compose or reply to a message in html mode
Select Options>>Format>>Plain& Rich text to avoid any internal AB decisions.
Send or save the message locally and observe the result

Results:
Two copies of the html message are sent even though multipart/alternative is indicated in the header.

This happens in: 
Mozilla/5.0 (Windows NT 5.0; rv:9.0a1) Gecko/20110923 Thunderbird/9.0a1 ID:20110923030159
Not seen in the 20110920 build.

I strongly suspect bug 679476 as the problem

Comment 1

[David :Bienvenu]

taking...

Comment 2

[David :Bienvenu]

Attachment: proposed fix

This is the part of the patch for bug 688991 where I messed this up:

-  if (NS_SUCCEEDED(status) && m_type && PL_strcasecmp(m_type, TEXT_PLAIN) )
+  if (NS_SUCCEEDED(status) && m_type.LowerCaseEqualsLiteral(TEXT_PLAIN) &&
+      m_desiredType.LowerCaseEqualsLiteral(TEXT_PLAIN))
   {
-    if (m_desired_type && !PL_strcasecmp(m_desired_type, TEXT_PLAIN) )

Comment 3

[David :Bienvenu]

fixed on trunk http://hg.mozilla.org/comm-central/rev/feb47379243c

Comment 4

[WADA:World Anti-bad-Duping Agency]

Verified with Mozilla/5.0 (Windows NT 5.1; rv:10.0a1) Gecko/20111001 Thunderbird/10.0a1