The default bug view has changed. See this FAQ.

drop the drop shadow on the back button for Windows 7

RESOLVED FIXED in Firefox 9

Status

()

Firefox
Theme
--
enhancement
RESOLVED FIXED
6 years ago
3 years ago

People

(Reporter: asa, Assigned: dao)

Tracking

Trunk
Firefox 9
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
Created attachment 562321 [details]
side by side view of back button with and without drop shadow

+++ This bug was initially created as a clone of Bug #603790 +++

We removed the drop shadows from most toolbar buttons in bug 603790. There's still a slight shadow effect created by having the bottom borders of the buttons be darker than the top borders. This is nice and looks great.

The one button that didn't get this same treatment is the large circular back button. That button still has a slight drop shadow.

That button is unique in our toolbar in that it's large and round and sort of sits "on top" of the forward button. It might make some "physical" sense for the back button to feel raised up off of the toolbar but I don't think it makes for an ideal visual sense. 

I propose that we fully drop the drop shadow on the back button and rely on the top and bottom border color differences to give it all the raised quality it needs. 

I've attached a screenshot of the current button and the minor modification to it I've made of removing the drop shadow. You can see the two side-by-side at regular size and magnified to see the differences. It's subtle, but I think it's a win.
If you ask me, they should be completely flat. But aside that, go for it!
(Assignee)

Comment 2

6 years ago
Created attachment 562364 [details] [diff] [review]
patch
Assignee: nobody → dao
Status: NEW → ASSIGNED
Attachment #562364 - Flags: review?(shorlander)
(Assignee)

Updated

6 years ago
No longer blocks: 544820, 638526
Attachment #562364 - Flags: review?(shorlander) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/mozilla-central/rev/dca24d75d9cc
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
Dão backed this out because it had a typo that broke the world.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: Firefox 9 → ---
(In reply to Joe Drew (:JOEDREW!) from comment #4)
> Dão backed this out because it had a typo that broke the world.

That was bug 687754 wasn't it?

Comment 6

6 years ago
Yes it was.
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 9
Whoops! Sorry.
You need to log in before you can comment on or make changes to this bug.