Last Comment Bug 689252 - cleanup/remove geo.wifi.* preferences
: cleanup/remove geo.wifi.* preferences
Status: RESOLVED FIXED
: addon-compat
Product: Core
Classification: Components
Component: Geolocation (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla9
Assigned To: Doug Turner (:dougt)
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: 710784
  Show dependency treegraph
 
Reported: 2011-09-26 12:33 PDT by Doug Turner (:dougt)
Modified: 2011-12-14 10:28 PST (History)
9 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v.1 (2.97 KB, patch)
2011-09-26 16:11 PDT, Doug Turner (:dougt)
josh: review+
Details | Diff | Splinter Review

Description Doug Turner (:dougt) 2011-09-26 12:33:47 PDT

    
Comment 1 Doug Turner (:dougt) 2011-09-26 16:11:59 PDT
Created attachment 562575 [details] [diff] [review]
patch v.1
Comment 2 Doug Turner (:dougt) 2011-09-27 07:25:16 PDT
https://hg.mozilla.org/mozilla-central/rev/ade33e515f46
Comment 3 Robert Kaiser 2011-09-28 07:41:06 PDT
Comment on attachment 562575 [details] [diff] [review]
patch v.1

>+    let providerUrlBase = "https://maps.googleapis.com/maps/api/browserlocation/json";

Is it legally OK that every Mozilla-based app, including SeaMonkey and any XULRunner application that would hook up Geolocation, is now automatically using this provider? I thought Google explicitly only lets us use this for actual Firefox?
I'm surely OK with having it be used by everybody, but I'm worried that Google may not agree with me here.
Comment 4 Jorge Villalobos [:jorgev] 2011-10-04 16:31:50 PDT
Why is this hard-coded now?
Comment 5 Dietrich Ayala (:dietrich) 2011-10-11 14:47:03 PDT
Why is this no longer configurable? There's not a single comment in this bug explaining the rationale.

This kills projects like Geomena dead. http://geomena.org/
Comment 6 Don Park [:donpdonp] 2011-10-11 15:03:31 PDT
A configurable geolocation provider is a critical freedom in locative web technology. Its as if Ubuntu decided to remove /etc/resolv.conf and hard code the DNS server IP address. Please restore this option. Both Firefox and Opera support this setting..

I started the geomena.org project to create a creative commons licensed alternative to the  wifi location databases of google, apple, and skyhook. Having the geo.wifi.url setting makes this possible.
Comment 7 Sonny Piers [:sonny] 2011-10-11 15:45:47 PDT
I would appreciate explanation too.
Comment 8 Doug Turner (:dougt) 2011-10-11 16:18:41 PDT
The preference is still honored, it is just not in about:config.
Comment 9 Don Park [:donpdonp] 2011-10-11 16:21:48 PDT
How is a firefox user meant to configure the geolocation provider, then?
Comment 10 Jorge Villalobos [:jorgev] 2011-10-11 16:33:10 PDT
Looking at the patch, we have this:

> -    let providerUrlBase = Services.prefs.getCharPref("geo.wifi.uri");
> +    let providerUrlBase = "https://maps.googleapis.com/maps/api/browserlocation/json";
> +    try {
> +        providerUrlBase = Services.prefs.getCharPref("geo.wifi.uri");      
> +    } catch (x) {};

So, the default value is no longer in the preferences, but the code still tries to see if there's anything set there and uses that value instead, if set.

In about:config it should still be possible to create a string preference with that name, and it should work correctly.
Comment 11 Don Park [:donpdonp] 2011-10-11 16:46:08 PDT
Thanks for pointing that out.
Comment 12 Doug Turner (:dougt) 2011-10-11 18:48:37 PDT
yup.  we currently do this for testing.
Comment 13 Sonny Piers [:sonny] 2011-10-12 08:09:25 PDT
I should have take a look in the patch.
Thanks.
Comment 14 Dietrich Ayala (:dietrich) 2011-10-12 09:17:19 PDT
(In reply to Sonny Piers from comment #13)
> I should have take a look in the patch.
> Thanks.

No worries. This confusion happens more easily when bugs don't have any comments or explanation. It got me too :)

Note You need to log in before you can comment on or make changes to this bug.