689292 - Make search results view for themes

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Search, defect)

Description

[krupa raj[:krupa]]

ES search results page for personas is not very useful right now. See

https://addons-dev.allizom.org/z/en-US/firefox/search/es?q=fire&atype=9

Comment 1

[krupa raj[:krupa]]

Same is true for themes search results: https://addons-dev.allizom.org/en-US/firefox/search/es?atype=2&q=test

Comment 2

[Jeff Balogh (:jbalogh)]

(In reply to krupa raj 82[:krupa] from comment #1)
> Same is true for themes search results:
> https://addons-dev.allizom.org/en-US/firefox/search/es?atype=2&q=test

That's about as useful as the old themes search.


(In reply to krupa raj 82[:krupa] from comment #0)
> ES search results page for personas is not very useful right now. See
> 
> https://addons-dev.allizom.org/z/en-US/firefox/search/es?q=fire&atype=9

cvan: There's code to detect ?cat=personas and ?cat=collections and fall back to the old search. Does that need to be modified?

Comment 3

[Christopher Van Wiemeersch [:cvan]]

Jeff: I have added a check for atype == PERSONA to also fall back to the old search.

At a glance it seems our appversions facet isn't picking up all Personas. I understand for Collections, but why are we falling back to the Sphinx pages for Personas?

I'll work on search/listing page styles for Personas, so I won't mark this as resolved.

Comment 4

[Jeff Balogh (:jbalogh)]

(In reply to Chris Van Wiemeersch [:cvan] from comment #3)
> At a glance it seems our appversions facet isn't picking up all Personas. I
> understand for Collections, but why are we falling back to the Sphinx pages
> for Personas?

To limit the scope of initial changes for ES. That didn't really work out since we couldn't ship anything until we got to phx.

Comment 5

[Wil Clouser [:clouserw]]

closing, we're focusing on marketplace+personas now.  We may need to file a similar bug, but it'll be a fresh context.