"sort" options on view menu of history should have mnemonics

RESOLVED FIXED in mozilla1.0.1

Status

SeaMonkey
UI Design
P3
minor
RESOLVED FIXED
17 years ago
11 years ago

People

(Reporter: Jesse Ruderman, Assigned: andreww)

Tracking

(Blocks: 1 bug, {access, fixed-seamonkey1.0})

Trunk
mozilla1.0.1
x86
Windows 98
access, fixed-seamonkey1.0

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt3])

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

17 years ago
The new "sort" options on the view menu of the bookmarks and history windows 
should have mnemonics in order to make those items easier to hit with the 
keyboard.

Bonus points if you use the same mnemonics for similar column names in both 
bookmarks and history, even when those items have slightly different names (bug 
68959).
(Reporter)

Comment 1

17 years ago
Blake has informed me that these menu items are actually not new.

Comment 2

17 years ago
Moving to XPApps and adding keywords.
Component: Bookmarks → XP Apps
Keywords: access, ui
Summary: "sort" options on view menu of bookmarks/history should have mnemonics → Keyboard Navigation for 'sort' menu

Comment 3

17 years ago
cc alec who owns the global history window.
(Reporter)

Comment 4

17 years ago
I like the old summary better.. it's easier to search for.
Summary: Keyboard Navigation for 'sort' menu → "sort" options on view menu of bookmarks/history should have mnemonics
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
.9.9
Priority: -- → P3
Target Milestone: mozilla1.0 → mozilla0.9.9
Keywords: nsbeta1

Comment 6

16 years ago
--> andreww
Assignee: ben → andreww
Status: ASSIGNED → NEW
Target Milestone: mozilla0.9.9 → mozilla1.0

Comment 7

16 years ago
approving nomination and accepting for Andrew. He's fixed a bunch o' these for
improved access. 
Status: NEW → ASSIGNED
Keywords: nsbeta1 → nsbeta1+
(Assignee)

Comment 8

16 years ago
Looks like the sorting is no longer in the bookmarks view menu,  but I still 
see it in the history view. 

Updating summary to reflect this.
Summary: "sort" options on view menu of bookmarks/history should have mnemonics → "sort" options on view menu of history should have mnemonics
(Assignee)

Comment 9

16 years ago
I should have know this wouldnt be a straightforward xul change. I need to 
talk to Ben to figure out how  the code here works:
http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/content/nsTreeU
tils.js#273

So that we can add a routine to add mnemonics to those lables.


Adding Ben to cc:
(Assignee)

Comment 10

16 years ago
Created attachment 72163 [details] [diff] [review]
changes to historyTreeOverlay.dtd, historyTreeOverlay.xul, nsTreeUtils.js

Thanks to Ben Goodger for the idea to add accesskey attributes to the tree
columns and then fetch them from the dom when needed like the labels already
are. 

Patch ready for review.
(Assignee)

Updated

16 years ago
Keywords: review

Comment 11

16 years ago
Comment on attachment 72163 [details] [diff] [review]
changes to historyTreeOverlay.dtd, historyTreeOverlay.xul, nsTreeUtils.js

sr=alecf
Attachment #72163 - Flags: superreview+

Comment 12

15 years ago
Comment on attachment 72163 [details] [diff] [review]
changes to historyTreeOverlay.dtd, historyTreeOverlay.xul, nsTreeUtils.js

r=varada
Attachment #72163 - Flags: review+
Comment on attachment 72163 [details] [diff] [review]
changes to historyTreeOverlay.dtd, historyTreeOverlay.xul, nsTreeUtils.js

sr=ben@netscape.com

Comment 14

15 years ago
Comment on attachment 72163 [details] [diff] [review]
changes to historyTreeOverlay.dtd, historyTreeOverlay.xul, nsTreeUtils.js

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #72163 - Flags: approval+
(Assignee)

Comment 15

15 years ago
fix checked into trunk.
(Assignee)

Comment 16

15 years ago
fix is in.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED

Comment 17

15 years ago
As far as  I can tell, this is not fixed. Looking at the patch I presume the
goal was to create mnemonics for the various sort options in the View menu,
including Sort by(Title|Location|Last Visited|First
Visited|Hostname|Referrer|Visit Count).

So there should be little underlines and the appropriate letters should work.
There are no underlines and none of the key commands work with a 2002032203
Win98 build.

Reopening. Let me know if I've read this incorrectly
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 18

15 years ago
No  you are right. Something is not  working properly. Checking it out 
asap.
Status: REOPENED → ASSIGNED

Comment 19

15 years ago
...history has been using outliner for quite a while now.  Did this ever work?
(Assignee)

Comment 20

15 years ago
Moving to 1.0.1.  
Target Milestone: mozilla1.0 → mozilla1.0.1

Updated

15 years ago
Whiteboard: [adt3]

Updated

15 years ago
Attachment #72163 - Attachment is obsolete: true

Comment 21

15 years ago
Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email adt@netscape.com.  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.
Keywords: nsbeta1-

Comment 22

15 years ago
Changing nsbeta1+ [adt3] bugs to nsbeta1- on behalf of the adt.  If you have any
questions about this, please email adt@netscape.com.  You can search for
"changing adt3 bugs" to quickly find and delete these bug mails.
Keywords: nsbeta1+

Updated

13 years ago
Blocks: 129179
Product: Core → Mozilla Application Suite
Created attachment 196774 [details] [diff] [review]
hooks up accesskeys on generated menuitems

Modifies nsTreeSorting.js to hook up the accesskey attribute from the
<treecol>'s with the generated menuitems.
Attachment #196774 - Flags: review?(neil.parkwaycc.co.uk)

Comment 24

12 years ago
Comment on attachment 196774 [details] [diff] [review]
hooks up accesskeys on generated menuitems

r+sr=me but you'll need to fix the "Sorted by Last Visited" access key before
you can check this in.
Attachment #196774 - Flags: review?(neil.parkwaycc.co.uk) → review+
Created attachment 197387 [details] [diff] [review]
hooks up accesskeys on generated menuitems v0.2

Fixes the conflicting accesskey. The two viable choices were 's' or 'e', so I
picked the one closest to the left.

Neil: If you sr, could you help me check this in?

I also noted that clicking on these headers actually don't work. It fails with
"JavaScript error: chrome://global/content/nsTreeSorting.js, line 67:
column.parentNode has no properties".

But I guess that's another bug.
Attachment #196774 - Attachment is obsolete: true
Attachment #197387 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #197387 - Flags: review+

Comment 26

12 years ago
Comment on attachment 197387 [details] [diff] [review]
hooks up accesskeys on generated menuitems v0.2

I decided on Last _Visited and Visit _Count.
Attachment #197387 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+

Comment 27

12 years ago
Fix checked in.

(In reply to comment #25)
> But I guess that's another bug.
Bug 257985 to be precise.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago12 years ago
Resolution: --- → FIXED

Comment 28

12 years ago
Comment on attachment 197387 [details] [diff] [review]
hooks up accesskeys on generated menuitems v0.2

(for the XPFE part of this patch only, of course)
Attachment #197387 - Flags: approval-seamonkey1.0?

Comment 29

12 years ago
Seamonkey-only portion of fix checked in to the 1.8 branch.
Whiteboard: [adt3] → [adt3] fixed-seamonkey1.0
Keywords: fixed-seamonkey1.0
Whiteboard: [adt3] fixed-seamonkey1.0 → [adt3]
You need to log in before you can comment on or make changes to this bug.