Brief flash of out-of-position content when keyboard opens with OGL layers on Galaxy Tab

RESOLVED FIXED in mozilla10

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Joe Drew (not getting mail), Assigned: ajuma)

Tracking

Trunk
mozilla10
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
This seems the same as bug 621745, but it persists on my Galaxy Tab despite the recent fixes.

Opening and closing the awesomescreen causes a brief flash of out-of-position content; either the texture is drawn too high or too low, depending on whether you're opening or closing the keyboard.
(Assignee)

Updated

6 years ago
Assignee: nobody → ajuma
(Assignee)

Comment 1

6 years ago
Created attachment 566532 [details] [diff] [review]
surfaceChanged shouldn't cause a frame of the previous size to be rendered on Honeycomb

In Bug 621745, it was discovered that when a surfaceChanged event occurs, we still need to draw one more frame at the old size since the buffer size only changes after the next eglSwapBuffer.

However, in Honeycomb, the buffer size is changing immediately. So when we draw a frame of the old size, we are either drawing a frame that is too large (e.g. when the keyboard appears) or too small (e.g. when the keyboard disappears).

This patch modifies the behaviour introduced in Bug 621745 so that we only draw a frame of the old size on pre-Honeycomb.
Attachment #566532 - Flags: review?(jmuizelaar)
(Assignee)

Updated

6 years ago
Blocks: 607684
Comment on attachment 566532 [details] [diff] [review]
surfaceChanged shouldn't cause a frame of the previous size to be rendered on Honeycomb

It would be nice to know what change caused this, but that will at least need to wait til Ice Cream Sandwich.
Attachment #566532 - Flags: review?(jmuizelaar) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/46ce491cec60
Target Milestone: --- → mozilla10

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/46ce491cec60
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.