Last Comment Bug 689680 - WebRTC: soundsystemproxy.cc missing include <stddef.h>
: WebRTC: soundsystemproxy.cc missing include <stddef.h>
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: ---
Assigned To: [:jesup] on pto until 2016/7/5 Randell Jesup
:
Mentors:
Depends on:
Blocks: webrtc
  Show dependency treegraph
 
Reported: 2011-09-27 11:57 PDT by [:jesup] on pto until 2016/7/5 Randell Jesup
Modified: 2011-09-27 20:06 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Trivial patch (1.32 KB, patch)
2011-09-27 12:03 PDT, [:jesup] on pto until 2016/7/5 Randell Jesup
no flags Details | Diff | Review

Description [:jesup] on pto until 2016/7/5 Randell Jesup 2011-09-27 11:57:47 PDT
WebRTC is missing #include <stddef.h> from soundsystemproxy.cc

Good test for upstreaming a patch
Comment 1 [:jesup] on pto until 2016/7/5 Randell Jesup 2011-09-27 12:03:16 PDT
Created attachment 562829 [details] [diff] [review]
Trivial patch

rs=me
Comment 2 [:jesup] on pto until 2016/7/5 Randell Jesup 2011-09-27 12:04:39 PDT
Committed as changeset 7b21e798ef60

Still needs upstreaming, per the whiteboard
Comment 3 Ralph Giles (:rillian) needinfo me 2011-09-27 12:11:39 PDT
This is reported upstream in https://webrtc-codereview.appspot.com/177001/

They rejected the patch, preferring to wait for their upstream patch to land in libjingle.
Comment 4 [:jesup] on pto until 2016/7/5 Randell Jesup 2011-09-27 20:06:09 PDT
Thanks Ralph.  So this isn't a great first case. :-)

Note You need to log in before you can comment on or make changes to this bug.