689809 - X to Close Addon Bar should be located on the right if platform isn't Mac OS X

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

As a follow-up bug from bug 657438, for consistency the close button on the addon bar should be located on the right-side if not on MACOSX.

Comment 1

[Dão Gottwald [:dao]]

I don't think bug 657438 should land without this... so not exactly a follow-up.

Comment 2

[Dão Gottwald [:dao]]

Attachment: patch

The add-on bar being customizable makes this fun -- actually moving the element probably isn't going to work.

Comment 3

[Matthew Wein [:mattw]]

Attachment: patch for bug 689809

The only issue I noticed was that the close button relocates back to the left while customizing the add-on bar. 

Adding the following should fix this:

  #addon-bar > #wrapper-addonbar-closebutton {
      -moz-box-ordinal-group: 2000;
  }

Let me know what you think.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 562968 [details] [diff] [review]
patch for bug 689809

>--- a/browser/themes/gnomestripe/browser/browser.css
>+++ b/browser/themes/gnomestripe/browser/browser.css

>+#addon-bar > #wrapper-addonbar-closebutton {
>+    -moz-box-ordinal-group: 2000;
>+}

1. this belongs in browser/base/content/browser.css (with ifdefs)
2. "#addon-bar > " is redundant
3. you can add #addonbar-closebutton to the selector and drop the browser.xul part of this patch
4. indentation is 2 spaces (not 4)

Comment 5

[Matthew Wein [:mattw]]

Attachment: patch for bug 689809 v2

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 565421 [details] [diff] [review]
patch for bug 689809 v2

There's another problem: The <statusbar>'s resizer (when displayed; http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.css#478) must be on the far right.

Comment 7

[Matthew N. [:MattN]]

The add-on bar was removed in Firefox 29.