Expose active state on current item of selectable widgets

RESOLVED FIXED in mozilla11

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 2 bugs, {access})

unspecified
mozilla11
access
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
This is requirement of ARIA spec - http://www.w3.org/TR/wai-aria-implementation/#keyboard-focus_aria-activedescendant

If ARIA widgets needs that native widgets should follow to be consistent.

IA2 provides IA2_STATE_ACTIVE which is described as:

This state can be used to indicate the current active item in a container, even 
  if the container itself is not currently active. In other words this would indicate
  the item that will get focus if you tab to the container.
(Assignee)

Comment 1

6 years ago
Created attachment 577231 [details] [diff] [review]
patch

besides we follow the spec this state should be useful for virtual cursor implementations when AT navigates the document without focus changing.
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #577231 - Flags: review?(bolterbugz)
(Assignee)

Comment 2

6 years ago
Created attachment 577236 [details] [diff] [review]
patch2

actually ARIA part was implemented in bug 403260. Make items of all widgets to expose active state.
Attachment #577231 - Attachment is obsolete: true
Attachment #577231 - Flags: review?(bolterbugz)
Attachment #577236 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #577236 - Flags: review? → review?(bolterbugz)
Comment on attachment 577236 [details] [diff] [review]
patch2

Review of attachment 577236 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. nice.

::: accessible/src/base/nsAccessible.cpp
@@ +1548,5 @@
> +    // descendant is the current one that would get focus if the user navigates
> +    // to the container widget.
> +    nsAccessible* widget = ContainerWidget();
> +    if (widget && widget->CurrentItem() == this)
> +      state |= states::ACTIVE;

Very nice change (I forgot about CurrentItem).
Attachment #577236 - Flags: review?(bolterbugz) → review+
(Assignee)

Comment 4

6 years ago
inbound land - https://hg.mozilla.org/integration/mozilla-inbound/rev/3a3633f1458c
https://hg.mozilla.org/mozilla-central/rev/3a3633f1458c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
(Assignee)

Updated

6 years ago
Flags: in-testsuite+
(Assignee)

Updated

5 years ago
Duplicate of this bug: 407597
You need to log in before you can comment on or make changes to this bug.