Closed
Bug 689882
Opened 13 years ago
Closed 12 years ago
Side effects of MOPS-store opcodes argument coersion are out of order
Categories
(Tamarin Graveyard :: Interpreter, defect)
Tamarin Graveyard
Interpreter
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: edwsmith, Assigned: wmaddox)
References
Details
Attachments
(2 files)
10.36 KB,
patch
|
Details | Diff | Splinter Review | |
2.46 KB,
patch
|
edwsmith
:
review+
|
Details | Diff | Splinter Review |
By inspection, the Verify/JIT pipeline does: coerce value -> int|Number coerce index -> int Whereas the abc/wordcode interpreters do: coerce index -> int coerce value -> int|Number I propose the JIT is correct because arguments are converted left-to-right on the stack, like calls. (Bug 624221 has a pending patch for the avmspec).
Reporter | ||
Updated•13 years ago
|
Blocks: interp_jit_semantics
Reporter | ||
Comment 1•13 years ago
|
||
Test case: $ abcasm intrinsics.abs $ avm intrinsics.abc store-args.as (yes, its eval-compatible) notice how output differs with -Dinterp or not. I haven't turned this into a standard test case, so not doing R? yet. Doing so requires at least using dir.asc_args, but also ensuring that runtest.py can compile intrinsics.abs on-demand and also with --rebuildtests.
Reporter | ||
Updated•13 years ago
|
Attachment #563417 -
Attachment description: mops store opcodes coerce args out of order. → Test case for mops-store opcodes.
Assignee | ||
Comment 2•12 years ago
|
||
Straightforward fix to align with JIT.
Assignee: nobody → wmaddox
Attachment #597234 -
Flags: review?(edwsmith)
Reporter | ||
Comment 3•12 years ago
|
||
Comment on attachment 597234 [details] [diff] [review] Coerce value before address when interpretings MOps stores Note that Brent already landed some or all (at least intrinsics.abs) of the test case files.
Attachment #597234 -
Flags: review?(edwsmith) → review+
Comment 4•12 years ago
|
||
changeset: 7226:ba888f512b73 user: William Maddox <wmaddox@adobe.com> summary: Bug 689882: Correct order in which coercions are applied to MOps store arguments (r=edwsmith) http://hg.mozilla.org/tamarin-redux/rev/ba888f512b73
Assignee | ||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•