Closed
Bug 690145
Opened 14 years ago
Closed 14 years ago
Move CharsetPopupMenu code from editorOverlay to editingOverlay
Categories
(SeaMonkey :: Composer, defect)
SeaMonkey
Composer
Tracking
(seamonkey2.7 fixed)
RESOLVED
FIXED
seamonkey2.7
| Tracking | Status | |
|---|---|---|
| seamonkey2.7 | --- | fixed |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
Attachments
(1 file)
|
3.51 KB,
patch
|
neil
:
review+
standard8
:
review+
|
Details | Diff | Splinter Review |
The CharsetPopupMenu code in editorOverlay is only used in Composer and Plain Text Editor so can be moved into editingOverlay
This patch does that.
Attachment #563213 -
Flags: review?(neil)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 563213 [details] [diff] [review]
Move CharsetPopupMenu code [Checked in: Comment 3]
I wondered what was going on here but it turns out that editor.xul has charsetOverlay.xul as an overlay and editorOverlay.xul then overlays the menupopup that charsetOverlay.xul adds...
I wonder whether the Revert function should allow the menuitems to be enabled again.
Attachment #563213 -
Flags: review?(neil) → review+
Comment on attachment 563213 [details] [diff] [review]
Move CharsetPopupMenu code [Checked in: Comment 3]
Requesting additional review for changes to shared file.
Attachment #563213 -
Flags: review?(mbanner)
|
||
Updated•14 years ago
|
Attachment #563213 -
Flags: review?(mbanner) → review+
Comment on attachment 563213 [details] [diff] [review]
Move CharsetPopupMenu code [Checked in: Comment 3]
http://hg.mozilla.org/comm-central/rev/c63ad16c02bc
Attachment #563213 -
Attachment description: Move CharsetPopupMenu code → Move CharsetPopupMenu code [Checked in: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
status-seamonkey2.7:
--- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.7
You need to log in
before you can comment on or make changes to this bug.
Description
•