Closed
Bug 690297
Opened 14 years ago
Closed 14 years ago
handling of boolean prefs in gfxPlatform broken by the PRBool->bool rewrite
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: jfkthame, Assigned: mwu)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
1.07 KB,
patch
|
jfkthame
:
review+
|
Details | Diff | Splinter Review |
In gfxPlatform, we have code that relied on being able to initialize PRBool variables to a special UNINITIALIZED_VALUE (-1), which lets us defer reading the actual prefs until they're needed. It looks like the rewrite to use bool will break this and make the prefs appear to be true before we've actually read them at all.
|
Assignee | |
Comment 1•14 years ago
|
||
This was actually detected by static analysis but I dropped this fix while I was cleaning up and uploading patches. :(
Assignee: nobody → mwu
Attachment #563359 -
Flags: review?(jfkthame)
|
|
Assignee | |
Comment 2•14 years ago
|
||
More cases fixed, switched to PRInt8.
Attachment #563359 -
Attachment is obsolete: true
Attachment #563359 -
Flags: review?(jfkthame)
Attachment #563363 -
Flags: review?(jfkthame)
|
Reporter | |
Comment 3•14 years ago
|
||
Comment on attachment 563363 [details] [diff] [review]
Fix v2
LGTM. Let's hope that's all of them! :)
Attachment #563363 -
Flags: review?(jfkthame) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•