In gfxPlatform, we have code that relied on being able to initialize PRBool variables to a special UNINITIALIZED_VALUE (-1), which lets us defer reading the actual prefs until they're needed. It looks like the rewrite to use bool will break this and make the prefs appear to be true before we've actually read them at all.
Created attachment 563359 [details] [diff] [review] Fix This was actually detected by static analysis but I dropped this fix while I was cleaning up and uploading patches. :(
Created attachment 563363 [details] [diff] [review] Fix v2 More cases fixed, switched to PRInt8.
Comment on attachment 563363 [details] [diff] [review] Fix v2 LGTM. Let's hope that's all of them! :)