69039 - Select User dialog pops up at inappropriate times

Status: VERIFIED FIXED

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Ilya Konstantinov]

The 'Select User' dialog box pops up only when the page containing the Login 
form has either fully loaded (with pictures etc.) or upon aborting loading.

Maybe aborting loading via Stop makes some sense, but leaving the page (by 
clicking a link etc.) also triggers a loading abort, and pops up a 'Select 
User' dialog box, even though we're already leaving the page.

When the site presents a Login form on each and every page, and you choose to 
ignore it, the 'Select User' window becomes VERY annoying to browse with.

Comment 1

[Keyser Sose]

Reporter what build were you using? And do you have a site we can reproduce this on?

Comment 2

[Ilya Konstantinov]

Every build up to the 0.8 release.

For example, http://www.ozon.ru/ will do. The page might take few seconds to 
load. Before it loads, I cannot force the username/password to be filled in. 
Once it finishes loading, or I abort it, or I'll leave the page (and thus 
abort it) - it fills in the username/password.

Now, if I have more than one username/password pair stored, it'll present a 
dialog box. But what good is this dialog box, if I'm leaving the page already 
(e.g. clicking a link) ?

Comment 3

[Keyser Sose]

Marking NEW.

Comment 4

[Viswanath Ramachandran]

nav triage: Steve - can you explain what this bug is saying. None of us 
understood what the "select user dialog" is. Does this have to be in 
m0.9.4, how important is this bug. thanks! Vishy

Comment 5

[Stephen P. Morse]

If you log into the same site at two different times with two different 
usernames, password manager will remember both.  Then when you return to the 
site it will give you a dialog asking which username you want to use.  That's 
the "select username" dialog referred to above.

Does it *have* to be in 0.9.4?  Of course not.  Nothing *has* to be there.  
Should it be there?  Probably yes because it leads to a very confusing UI 
otherwise (user cancels a load and suddenly gets a message asking him to select 
from a list of possible usernames).

Comment 6

[rpotts (gone)]

Attachment: Patch to nsWalletService.cpp...

Comment 7

[rpotts (gone)]

Hi Steve,

i think that the above patch should fix this problem...  let me know.

-- rick

Comment 8

[Stephen P. Morse]

That was too easy.  I tried that same thing in July when I first got serious 
about fixing this bug and it didn't work then -- the status being passed in was 
always 0 even when the loading was aborted.  Anyway, I'm glad it's working 
correctly now.

r=morse

cc'ing darin for sr

Comment 9

[rpotts (gone)]

It sounds like there was a bug in the nsDocLoader/nsWebProgressListener when you
tried the fix last month :-(

At least everything is working as it's supposed to now :-)

Comment 10

[Darin Fisher]

so with this patch, aborting the bugzilla login page will no longer give me my
username and password fields, right?  for some reason the login page never loads
quickly, and so it is always nice to just stop the page and then press login...
to bad this feature is now going to have to go away.  oh well.

sr=darin

Comment 11

[rpotts (gone)]

patch checked in.

Comment 12

[Stephen P. Morse]

So now see bug 96131.  It just goes to show that you can't please everybody.

Comment 13

[Ilya Konstantinov]

1. The username/password should be filled in as soon as the form arrives (why do we wait for the entire document to load anyway?). If there are more than one combination, the Select User dialog box should pop up.2. There should be a "Don't ask me again for this session" checkbox in the Select User dialog box.3. Once disabled, the functionality still needs to be triggerable via the input box's context menu.

Comment 14

[Terri Preston]

Verified patch checked into lxr.mozilla.org