Closed
Bug 690419
Opened 13 years ago
Closed 13 years ago
Script debugger picks the wrong highlighting engine in URLs with a query string
Categories
(DevTools :: Debugger, defect, P2)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: past, Assigned: past)
References
Details
Attachments
(2 files, 3 obsolete files)
|
10.87 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
|
918 bytes,
patch
|
Details | Diff | Splinter Review |
The conditional that picks between JavaScript and HTML source highlighting should strip the query string from the URL first.
|
Assignee | |
Updated•13 years ago
|
Component: Developer Tools → Developer Tools: Debugger
QA Contact: developer.tools → developer.tools.debugger
|
|
Assignee | |
Updated•13 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 1•13 years ago
|
||
A similar issue is that the highlighting engine is not updated when the selected script is changed.
Assignee: nobody → past
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•13 years ago
|
||
This patch fixes both issues.
Attachment #592167 -
Flags: review?(dcamp)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Improved the mochitest a bit.
Attachment #592167 -
Attachment is obsolete: true
Attachment #592167 -
Flags: review?(dcamp)
Attachment #592700 -
Flags: review?(dcamp)
|
||
Comment 4•13 years ago
|
||
We're fetching source from necko, right? Can we do this with server-provided content types rather than filename sniffing?
|
|
Assignee | |
Comment 5•13 years ago
|
||
(In reply to Dave Camp (:dcamp) from comment #4)
> We're fetching source from necko, right? Can we do this with
> server-provided content types rather than filename sniffing?
Yep, for non-local scripts we sure can. Thanks!
Attachment #592700 -
Attachment is obsolete: true
Attachment #592700 -
Flags: review?(dcamp)
Attachment #594147 -
Flags: review?(dcamp)
|
|
||
Updated•13 years ago
|
Attachment #594147 -
Flags: review?(dcamp) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
Made a small test fix required after the last merge with fx-team.
Attachment #594147 -
Attachment is obsolete: true
Attachment #595828 -
Flags: review?(dcamp)
|
|
Assignee | |
Comment 7•13 years ago
|
||
These are the changes.
|
|
||
Updated•13 years ago
|
Attachment #595828 -
Flags: review?(dcamp) → review+
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [land-in-fx-team]
|
|
Assignee | |
Updated•13 years ago
|
Attachment #595828 -
Attachment description: Working patch v4 → [in-fx-team] Working patch v4
|
|
Assignee | |
Comment 8•13 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
|
||
Comment 9•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•