Last Comment Bug 690419 - Script debugger picks the wrong highlighting engine in URLs with a query string
: Script debugger picks the wrong highlighting engine in URLs with a query string
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Debugger (show other bugs)
: Trunk
: All All
: P2 normal (vote)
: Firefox 13
Assigned To: Panos Astithas [:past]
:
: James Long (:jlongster)
Mentors:
Depends on:
Blocks: minotaur
  Show dependency treegraph
 
Reported: 2011-09-29 10:27 PDT by Panos Astithas [:past]
Modified: 2012-02-13 06:55 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Working patch (8.92 KB, patch)
2012-01-27 09:51 PST, Panos Astithas [:past]
no flags Details | Diff | Splinter Review
Working patch v2 (9.17 KB, patch)
2012-01-30 06:55 PST, Panos Astithas [:past]
no flags Details | Diff | Splinter Review
Working patch v3 (10.79 KB, patch)
2012-02-03 05:46 PST, Panos Astithas [:past]
dcamp: review+
Details | Diff | Splinter Review
[in-fx-team] Working patch v4 (10.87 KB, patch)
2012-02-09 11:19 PST, Panos Astithas [:past]
dcamp: review+
Details | Diff | Splinter Review
Diff between v3 and v4 (918 bytes, patch)
2012-02-09 11:20 PST, Panos Astithas [:past]
no flags Details | Diff | Splinter Review

Description Panos Astithas [:past] 2011-09-29 10:27:12 PDT
The conditional that picks between JavaScript and HTML source highlighting should strip the query string from the URL first.
Comment 1 Panos Astithas [:past] 2012-01-27 07:46:06 PST
A similar issue is that the highlighting engine is not updated when the selected script is changed.
Comment 2 Panos Astithas [:past] 2012-01-27 09:51:38 PST
Created attachment 592167 [details] [diff] [review]
Working patch

This patch fixes both issues.
Comment 3 Panos Astithas [:past] 2012-01-30 06:55:26 PST
Created attachment 592700 [details] [diff] [review]
Working patch v2

Improved the mochitest a bit.
Comment 4 Dave Camp (:dcamp) 2012-02-02 18:00:03 PST
We're fetching source from necko, right?  Can we do this with server-provided content types rather than filename sniffing?
Comment 5 Panos Astithas [:past] 2012-02-03 05:46:23 PST
Created attachment 594147 [details] [diff] [review]
Working patch v3

(In reply to Dave Camp (:dcamp) from comment #4)
> We're fetching source from necko, right?  Can we do this with
> server-provided content types rather than filename sniffing?

Yep, for non-local scripts we sure can. Thanks!
Comment 6 Panos Astithas [:past] 2012-02-09 11:19:59 PST
Created attachment 595828 [details] [diff] [review]
[in-fx-team] Working patch v4

Made a small test fix required after the last merge with fx-team.
Comment 7 Panos Astithas [:past] 2012-02-09 11:20:44 PST
Created attachment 595829 [details] [diff] [review]
Diff between v3 and v4

These are the changes.
Comment 8 Panos Astithas [:past] 2012-02-11 05:48:59 PST
https://hg.mozilla.org/integration/fx-team/rev/7b6bf801d765
Comment 9 Tim Taubert [:ttaubert] 2012-02-13 06:55:29 PST
https://hg.mozilla.org/mozilla-central/rev/7b6bf801d765

Note You need to log in before you can comment on or make changes to this bug.