Script debugger picks the wrong highlighting engine in URLs with a query string

RESOLVED FIXED in Firefox 13

Status

()

Firefox
Developer Tools: Debugger
P2
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: past, Assigned: past)

Tracking

Trunk
Firefox 13
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

The conditional that picks between JavaScript and HTML source highlighting should strip the query string from the URL first.
Blocks: 676586
Component: Developer Tools → Developer Tools: Debugger
QA Contact: developer.tools → developer.tools.debugger
Priority: -- → P2
A similar issue is that the highlighting engine is not updated when the selected script is changed.
Assignee: nobody → past
Status: NEW → ASSIGNED
Created attachment 592167 [details] [diff] [review]
Working patch

This patch fixes both issues.
Attachment #592167 - Flags: review?(dcamp)
Created attachment 592700 [details] [diff] [review]
Working patch v2

Improved the mochitest a bit.
Attachment #592167 - Attachment is obsolete: true
Attachment #592167 - Flags: review?(dcamp)
Attachment #592700 - Flags: review?(dcamp)

Comment 4

6 years ago
We're fetching source from necko, right?  Can we do this with server-provided content types rather than filename sniffing?
Created attachment 594147 [details] [diff] [review]
Working patch v3

(In reply to Dave Camp (:dcamp) from comment #4)
> We're fetching source from necko, right?  Can we do this with
> server-provided content types rather than filename sniffing?

Yep, for non-local scripts we sure can. Thanks!
Attachment #592700 - Attachment is obsolete: true
Attachment #592700 - Flags: review?(dcamp)
Attachment #594147 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #594147 - Flags: review?(dcamp) → review+
Created attachment 595828 [details] [diff] [review]
[in-fx-team] Working patch v4

Made a small test fix required after the last merge with fx-team.
Attachment #594147 - Attachment is obsolete: true
Attachment #595828 - Flags: review?(dcamp)
Created attachment 595829 [details] [diff] [review]
Diff between v3 and v4

These are the changes.

Updated

6 years ago
Attachment #595828 - Flags: review?(dcamp) → review+
Whiteboard: [land-in-fx-team]
Attachment #595828 - Attachment description: Working patch v4 → [in-fx-team] Working patch v4
https://hg.mozilla.org/integration/fx-team/rev/7b6bf801d765
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/7b6bf801d765
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
You need to log in before you can comment on or make changes to this bug.