690523 - Provide status in the response for update an add-on

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[Piotr Zalewa [:zalun]]

it contains currently 'statuses': [1], but I've no idea how to read it.

Comment 1

[Wil Clouser [:clouserw]]

These are defined in https://github.com/jbalogh/zamboni/blob/master/apps/constants/base.py

Easiest would be just to copy that list to builder.

Comment 2

[Piotr Zalewa [:zalun]]

I've got it copied, the issue being it is a list - I assume there might be more than one answer

Comment 3

[Wil Clouser [:clouserw]]

An add-on can only have one status, so not sure about that.  Andy?

Comment 4

[Andy McKay]

If you could let me know what URL you are hitting on the API then I can spot the handler easily. I have a feeling you are hitting the version API and in that case a version does not have a status, its only the addon or the file.

This is the status of each file in the version, which 99% of the time will be the same. We can remove that and do an API for each file (I think I saw another bug on that fly by earlier).

Comment 5

[Piotr Zalewa [:zalun]]

This is the OAuth api to upload new file to the existing add-on.

That's the full response:

Sep 29 13:34:50 pm-gearman-amo02.mozilla.org: [<anon>][None] f.jetpack:DEBUG AMOOAUTHAPI: update response: {u'addon_id': 337448, u'license': None, u'created': u'2011-09-29 13:34:39', u'apps': [{u'application_id': 1, u'_state': u'<django.db.models.base.ModelState object at 0x7fb0e644d4d0>', u'version_id': 1270699, u'min_id': 349, u'from_cache': False, u'max_id': 397, u'id': 124385}], u'current': False, u'version': u'test', u'release_notes': None, u'id': 1270699, u'statuses': [1]}  :/data/amo_python/www/builder.preview/flightdeck/apps/jetpack/models.py:213

There was a bug about adding status to this response. I don't remember the number.

Comment 6

[Andy McKay]

The field statuses is the status of each file in the version. I've just changed this to be a list of lists [file.id, file.status], so you can distinguish between the different statuses. For an add version, its pretty easy, you only have one file present.

https://github.com/jbalogh/zamboni/commit/c4ec66