690570 - e10s add-on support for nsIFormSubmitObserver

Status: REOPENED

(Core :: DOM: Core & HTML, defect, P5)

Description

[:Gavin Sharp [email: [e-mail]]]

The form element validation code currently works by looking for nsIFormSubmitObservers registered with the observer service, and and lets them deal with displaying the UI for the form submission (a xul:panel anchored to the element in Firefox's case). We need to find some other way to implement that's e10s-friendly.

Comment 1

[Jim Mathies [:jimm]]

Reopening this. My initial look into this centered on the browser's use of the 'invalidformsubmit' observer. However, I did some searches across the addon database and found that addons are using some of these events, specifically:

earlyformsubmit - about 25 uses
formsubmit - 0 uses
firstformsubmit - 0 uses
invalidformsubmit - 1 use

Comment 2

[Jim Mathies [:jimm]]

http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/HTMLFormElement.cpp#913

Looks like 'earlyformsubmit', 'firstformsubmit', and 'formsubmit' can be sent over via an e10s call and fired in the parent, they both carry a window pointer, action url string, and a cancel flag.

'invalidformsubmit' however carries with it a list of elements, not sure what to do about those.

Comment 3

[Jim Mathies [:jimm]]

Per a discussion in our weekly meeting, we plan to land the front end fix for the browser, and address addon usage of this api through the addon compat layer we're working on.

Comment 4

[Allison Naaktgeboren :ally]

addon compat, sounds like my department these days.

Comment 5

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.