690635 - Issues with camera input on DroidX

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Wesley Johnston (:wesj)]

When I try to use camera input on my phone all I get is a black box.

I've been playing with a simple Android apps and find that I basically have to call setPreviewDisplay in order to receive any frames in the PreviewCallback. AFAICT, we never call it. The docs read like the camera should not work without calling setPreviewDisplay, so I'm either surprised that camera input works on any phones, or surprised that I have the one that actually follows the spec.

Comment 1

[Matt Brubeck (:mbrubeck)]

Requesting tracking-firefox9 because this is a bug in a new feature in Firefox 9 (camera support, bug 659188) that appears to make it unusable on some devices.  We'll want to fix this on Aurora if we can, or discuss turning off the feature for release.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

What's the status here?

Comment 3

[Wesley Johnston (:wesj)]

I spent some time on Monday playing with this. Fabrice pointed me to some older patches of his which did attach a SurfaceView to the camera. I was receiving "Surface is NULL" (or something along those lines) messages in logcat.

Comment 4

[[:fabrice] Fabrice Desré]

Attachment: patch

Fix by setting up a hidden SurfaceView for the camera preview. We use a 8x16 size since some phones don't like a 1x1 preview surface (http://soledadpenades.com/2011/04/05/native-startpreview-failed-on-nexus-s-check-your-preview-size/)

Comment 6

[[:fabrice] Fabrice Desré]

pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f04220527e2a

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f04220527e2a

Comment 8

[[:fabrice] Fabrice Desré]

Comment on attachment 566094 [details] [diff] [review]
patch

low risk patch that increases our device support for camera

Comment 9

[Matt Brubeck (:mbrubeck)]

To clarify, we are asking for approval for Firefox 9 (currently on Aurora but migrating to beta on November 8).  This fixes a bug in the new camera feature in Firefox 9 that makes the camera unusable on some devices.  The patch is Android-only, and has been in the nightly channel for several weeks.  One regression was found in that time (bug 694795); we have a fix for it and are requesting approval for that fix too.

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 566094 [details] [diff] [review]
patch

[Triage Comment]
Approving for Beta 9 to ensure camera input is working on correctly on all mobile devices.

Comment 11

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/releases/mozilla-beta/rev/27e13d1326c3

Comment 12

[Catalin Suciu [:csuciu]]

I verified this on the latest Beta using www.people.mozilla.com/~fdesre/capture. On Motorola Droid Pro the bug is reproducible. When I press capture on the test page a black box is displayed where the capture should be. Also the framing of the picture box is not correct - see the attached screenshot.
Tested this on some other devices and the issue is not reproducible for them.

Comment 13

[Catalin Suciu [:csuciu]]

Attachment: Moto Droid Pro screenshot

Comment 14

[Carla Nadastean]

Bug is also reproducible on Motorola Droid 2 (Android 2.3):
Build ID:
Mozilla/5.0(Android; Linux arm7l; rv:9.0) Gecko/20111116 Firefox/9.0 Fennec/9.0

Comment 15

[Kevin Brosnan [Ex-Mozilla]]

Tracking '-' on Native we use the OS provided camera.

Comment 16

[BMO Automation]

Closing all opened bug in a graveyard component