694795 - Black rectangle in top left corner after opening a link from another app

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: screenshot

Steps to reproduce:
1. Open fennec on Android
2. Switch to another app and tap on a link
3. Choose to open the link in fennec

Expected results: Fennec reappears and the link opens in a new tab.

Results: Fennec reappears and the link opens in a new tab, *and* a small black rectangle appears in the top left corner of the screen.  The black rectangle remains fixed in the corner, obscuring whatever Fennec chrome or content is there.

I can't reproduce this by following similar steps in desktop Fennec.  It happens only when opening a link from another Android app while Fennec is already running.  Just opening a link in a new tab does not trigger the bug, nor does launching fennec by tapping a link from another app.

This bug occurs in Nightly 10.0a1 (I first noticed it in the 2011-10-14 build, but I don't know exactly which builds are affected).  It does not occur in Aurora 9.0a2.

Comment 1

[[:fabrice] Fabrice Desré]

This is due to the camera support added in bug 690635 for some devices.

Matt, you can assign it to me if you prefer.

Comment 2

[Matt Brubeck (:mbrubeck)]

Sure!  Thanks.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

696001 shows a different way to get to the same problem.

Comment 5

[Cristian Nicolae (:xti)]

I was always able to reproduce this issue while I've performed the str from bug 696013

Comment 6

[[:fabrice] Fabrice Desré]

Attachment: patch

Fixed by adding the camera view only when we need it. It looks like it was popping on top of the gecko surfaceview each time fennec was paused/resumed (eg just choosing "browse" to get the filepicker chooser was enough to trigger the bug)

Comment 7

[Matt Brubeck (:mbrubeck)]

Comment on attachment 572123 [details] [diff] [review]
patch

The code looks good.  Has it been tested to make sure it works on phones that were affected by bug 690635?

Comment 8

[[:fabrice] Fabrice Desré]

Yes, I tested on two phones that had this problem, along with a couple others an a galaxy tab 10.1

Comment 9

[[:fabrice] Fabrice Desré]

pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c9cae22054b

Comment 10

[[:fabrice] Fabrice Desré]

Comment on attachment 572123 [details] [diff] [review]
patch

fixes a bug introduced by Bug 690635

Comment 11

[Matt Brubeck (:mbrubeck)]

To clarify, we are asking for approval for Firefox 9 (currently on Aurora but migrating to beta on November 8).  See bug 690635 comment 9 for details.

Comment 12

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/1c9cae22054b

Comment 13

[Alex Keybl [:akeybl]]

Comment on attachment 572123 [details] [diff] [review]
patch

[Triage Comment]
Approving for Beta 9 to ensure camera input is working on correctly on all mobile devices.

Comment 14

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/releases/mozilla-beta/rev/605655ace7f9

Comment 15

[Catalin Suciu [:csuciu]]

Verified fixed on Mozilla/5.0 (Android; Linux armv7l; rv:9.0) Gecko/20111116 Firefox/9.0 Fennec/9.0