The prefs pane patch changed the style of our buttons. I think it accidently made buttons on prompts/dialogs/etc slightly smaller. We should make them big again.
Created attachment 563814 [details] [diff] [review]
A padding was missing. This has been added.
Pushed to inbound:
Aurora 9 is not currently affected, but we should request approval if we decide to land bug 682412 on Aurora.
(In reply to Matt Brubeck (:mbrubeck) from comment #2)
> Pushed to inbound:
Code changes, no matter how trivial, shouldn't be DONTBUILD. If some test breaks (yes, unexpectedly!), the initial blame is going to be on the subsequent landing (me in this case).
(In reply to Dão Gottwald [:dao] from comment #3)
> Code changes, no matter how trivial, shouldn't be DONTBUILD. If some test
> breaks (yes, unexpectedly!), the initial blame is going to be on the
> subsequent landing (me in this case).
Okay, sure. I was thinking of this as NPOTB because it was in a file that's used only on an platform (Android 3.0) that we don't have automated test machines for. But I'll try to err on the side of more testing instead instead of less. (I'm also the person who has personally backed out most of the breakage on inbound in the past week, so I am of course sympathetic to anything that makes that process easier.)
Comment on attachment 563814 [details] [diff] [review]
Simple cleanup fix
Mozilla/5.0 (Android;Linux armv7l;rv:10.0a1)Gecko/20110929 Firefox/9.0a2 Fennec/9.0a2
Device: HTC Desire Z
OS: Android 2.3
Verified on latest Aurora build, prompts/dialogs/buttons... seem ok, but how do we know exactly how big should the prompts/buttons be? How can we verify this?
Marking bug as verified since there is no longer an issue with dialog buttons height.
Mozilla/5.0 (Android;Linux armv7l;rv:10.0)Gecko/20111228 Firefox/10.0 Fennec/10.0
Device: Samsung Galaxy S2
OS: Android 2.3