Closed Bug 690870 Opened 10 years ago Closed 10 years ago
[TABLETUI] Add white horizontal divider after first group of Sync JPAKE characters
Remove the white horizontal divider above the last group of Sync JPAKE characters -- Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20110930 Firefox/10.0a1 Fennec/10.0a1 Galaxy Tab 10.1 (Android 3.1)
Do we want to remove the white line or add a white line between the first and second boxes? I would have thought we'd add a white separator
there should be two white separators http://www.flickr.com/photos/61892693@N03/6169097025/in/photostream
Summary: [TABLETUI] Remove white horizontal divider above last group of Sync JPAKE characters → [TABLETUI] Add white horizontal divider after first group of Sync JPAKE characters
This patch works fine but, to be honest, I'm not entirely sure why. The first description element in the sync code vbox is getting an tiny extra margin somehow. I couldn't find the corresponding CSS selector that is causing that. Forcing the margin of first description to be 0 fixes the issue.
Assignee: nobody → lucasr.at.mozilla
Attachment #564167 - Flags: review?(mark.finkle)
FYI: the DOM inspector didn't show anything interesting regarding this. All description elements with .syncsetup-code class have the same computed style.
Comment on attachment 564167 [details] [diff] [review] Add missing separator between sync code numbers Is this something we need to add to _all_ descriptions?
(In reply to Mark Finkle (:mfinkle) from comment #5) > Comment on attachment 564167 [details] [diff] [review] [diff] [details] [review] > Add missing separator between sync code numbers > > Is this something we need to add to _all_ descriptions? This patch removes 1-2px margin that only applies to the first-child description. I wonder why we'd want to keep this strange extra margin for other description elements. I can move this fix to apply only to syncsetup-code class if you feel strongly about it.
I think this margin is the problem: http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/honeycomb/browser.css#1795 margin_xtiny = 0.11mozmmm and I think that is too small. It could be causing a rounding error. Let's try manually bumping up that margin a bit to see if we get the desired affect without rounding issues.
Comment on attachment 564167 [details] [diff] [review] Add missing separator between sync code numbers I feel strongly that we don't want this rule in platform.css
Attachment #564167 - Flags: review?(mark.finkle) → review-
You're right, bumping margin_xtiny to 0.15mozmm fixes the problem. margin_xtiny is not used in many places. This bump doesn't seem to break anything.
Comment on attachment 564292 [details] [diff] [review] Bump magin_xtiny from 0.11mozmm to 0.15mozmm Please update froyo and gingerbread margin_xtiny too
Attachment #564292 - Flags: review?(mark.finkle) → review+
This bug is currently not in Firefox 9, but we should check whether it appears on Aurora after we land other theme patches there, and backport this fix too if it does.
tracking-fennec: --- → ?
Target Milestone: --- → Firefox 10
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Since bug 682412 landed on Aurora, this has regressed there too.
Comment on attachment 564292 [details] [diff] [review] Bump magin_xtiny from 0.11mozmm to 0.15mozmm Requesting approval for Aurora 9. This mobile-only patch just changes one constant in our CSS to avoid rounding errors, to fix a regression that makes the sync dialog look ugly. The fix has already been in nightly for several days.
Attachment #564292 - Flags: approval-mozilla-aurora?
Attachment #564292 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Nightly Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111007 Firefox/10.0a1 Fennec/10.0a1
Landed in Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/b2f1ffa12cd2
Verified fixed on Aurora Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20111013 Firefox/9.0a2 Fennec/9.0a2 White horizontal divider exists after first and second group of Sync JPAKE characters.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.