Closed
Bug 690870
Opened 13 years ago
Closed 13 years ago
[TABLETUI] Add white horizontal divider after first group of Sync JPAKE characters
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox9 fixed, firefox10 fixed)
VERIFIED
FIXED
Firefox 9
People
(Reporter: aaronmt, Assigned: lucasr)
References
Details
(Keywords: regression)
Attachments
(2 files, 1 obsolete file)
14.21 KB,
image/png
|
Details | |
1.05 KB,
patch
|
mfinkle
:
review+
asa
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Remove the white horizontal divider above the last group of Sync JPAKE characters
--
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20110930 Firefox/10.0a1 Fennec/10.0a1
Galaxy Tab 10.1 (Android 3.1)
Reporter | ||
Updated•13 years ago
|
Comment 1•13 years ago
|
||
Do we want to remove the white line or add a white line between the first and second boxes?
I would have thought we'd add a white separator
Comment 2•13 years ago
|
||
there should be two white separators
http://www.flickr.com/photos/61892693@N03/6169097025/in/photostream
Updated•13 years ago
|
Summary: [TABLETUI] Remove white horizontal divider above last group of Sync JPAKE characters → [TABLETUI] Add white horizontal divider after first group of Sync JPAKE characters
Assignee | ||
Comment 3•13 years ago
|
||
This patch works fine but, to be honest, I'm not entirely sure why. The first description element in the sync code vbox is getting an tiny extra margin somehow. I couldn't find the corresponding CSS selector that is causing that. Forcing the margin of first description to be 0 fixes the issue.
Assignee: nobody → lucasr.at.mozilla
Attachment #564167 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 4•13 years ago
|
||
FYI: the DOM inspector didn't show anything interesting regarding this. All description elements with .syncsetup-code class have the same computed style.
Comment 5•13 years ago
|
||
Comment on attachment 564167 [details] [diff] [review]
Add missing separator between sync code numbers
Is this something we need to add to _all_ descriptions?
Assignee | ||
Comment 6•13 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #5)
> Comment on attachment 564167 [details] [diff] [review] [diff] [details] [review]
> Add missing separator between sync code numbers
>
> Is this something we need to add to _all_ descriptions?
This patch removes 1-2px margin that only applies to the first-child description. I wonder why we'd want to keep this strange extra margin for other description elements.
I can move this fix to apply only to syncsetup-code class if you feel strongly about it.
Comment 7•13 years ago
|
||
I think this margin is the problem:
http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/honeycomb/browser.css#1795
margin_xtiny = 0.11mozmmm and I think that is too small. It could be causing a rounding error. Let's try manually bumping up that margin a bit to see if we get the desired affect without rounding issues.
Comment 8•13 years ago
|
||
Comment on attachment 564167 [details] [diff] [review]
Add missing separator between sync code numbers
I feel strongly that we don't want this rule in platform.css
Attachment #564167 -
Flags: review?(mark.finkle) → review-
Assignee | ||
Comment 9•13 years ago
|
||
You're right, bumping margin_xtiny to 0.15mozmm fixes the problem. margin_xtiny is not used in many places. This bump doesn't seem to break anything.
Attachment #564167 -
Attachment is obsolete: true
Attachment #564292 -
Flags: review?(mark.finkle)
Comment 10•13 years ago
|
||
Comment on attachment 564292 [details] [diff] [review]
Bump magin_xtiny from 0.11mozmm to 0.15mozmm
Please update froyo and gingerbread margin_xtiny too
Attachment #564292 -
Flags: review?(mark.finkle) → review+
Comment 11•13 years ago
|
||
This bug is currently not in Firefox 9, but we should check whether it appears on Aurora after we land other theme patches there, and backport this fix too if it does.
tracking-fennec: --- → ?
Assignee | ||
Comment 12•13 years ago
|
||
Target Milestone: --- → Firefox 10
Comment 13•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 14•13 years ago
|
||
Since bug 682412 landed on Aurora, this has regressed there too.
Comment 15•13 years ago
|
||
Comment on attachment 564292 [details] [diff] [review]
Bump magin_xtiny from 0.11mozmm to 0.15mozmm
Requesting approval for Aurora 9. This mobile-only patch just changes one constant in our CSS to avoid rounding errors, to fix a regression that makes the sync dialog look ugly. The fix has already been in nightly for several days.
Attachment #564292 -
Flags: approval-mozilla-aurora?
Updated•13 years ago
|
Attachment #564292 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Reporter | ||
Comment 16•13 years ago
|
||
Verified fixed on Nightly
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111007 Firefox/10.0a1 Fennec/10.0a1
Assignee | ||
Comment 17•13 years ago
|
||
Landed in Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/b2f1ffa12cd2
Assignee | ||
Updated•13 years ago
|
Assignee | ||
Updated•13 years ago
|
Target Milestone: Firefox 10 → Firefox 9
Comment 18•13 years ago
|
||
Verified fixed on Aurora
Mozilla/5.0 (Android; Linux armv7l; rv:9.0a1) Gecko/20111013 Firefox/9.0a2 Fennec/9.0a2
White horizontal divider exists after first and second group of Sync JPAKE characters.
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
tracking-fennec: ? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•